Refactor enhance auth localization #25
Conversation
This commit adds the corresponding Arabic translations for the new and updated authentication keys. It revises the wording to be more professional and security-conscious, aligning with the changes previously made to the English localizations.
Refactored the `AuthenticationPage` to use localization keys directly from `l10n` for its headline and subheadline. This removes the need to pass these strings as parameters, making the widget more self-contained and easier to maintain. The `showAnonymousButton` parameter has also been removed, as anonymous sign-in is not a feature of the secure dashboard. BREAKING CHANGE: The constructor for `AuthenticationPage` no longer accepts `headline`, `subHeadline`, or `showAnonymousButton` parameters. Calls to this widget must be updated to remove these arguments.
Removes the now-deleted `headline`, `subHeadline`, and `showAnonymousButton` parameters from the `AuthenticationPage` constructor within the GoRouter configuration. This aligns the router with the recent localization and simplification of the `AuthenticationPage` widget.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on refactoring the authentication module to fully leverage localization for all user-facing text. The primary goal is to eliminate hardcoded strings within the UI components, particularly on the main authentication and request code pages, thereby enhancing internationalization capabilities and streamlining the codebase for future maintenance.
Highlights
- Authentication Page Refactor: The
AuthenticationPagehas been refactored to remove hardcodedheadline,subHeadline, andshowAnonymousButtonproperties. These display texts are now sourced directly from localization files, simplifying the widget's constructor and promoting better internationalization practices. - Enhanced Localization for Auth Flow: New localization keys (
authenticationPageHeadline,authenticationPageSubheadline) have been introduced for the main authentication page. Additionally, existing localization keys for the email sign-in and request code pages (emailSignInPageTitle,requestCodePageHeadline,requestCodePageSubheadline) have been updated with clearer, more secure-sounding phrasing across English and Arabic locales. - Code Maintainability Improvements: By centralizing UI text into localization files, the pull request improves code maintainability and prepares the application for easier multi-language support. Minor formatting adjustments and import reordering were also applied across several files for consistency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors the authentication pages to use localization, which improves maintainability. The updated copy clarifies the intended audience (administrators and publishers). I've suggested removing redundant text on the 'request code' screen to improve the user experience.
| "@emailSignInPageTitle": { | ||
| "description": "عنوان صفحة تسجيل الدخول بالبريد الإلكتروني" | ||
| }, | ||
| "requestCodePageHeadline": "سجل الدخول أو أنشئ حسابًا", | ||
| "requestCodePageHeadline": "تسجيل دخول آمن بالبريد الإلكتروني", |
There was a problem hiding this comment.
The requestCodePageHeadline is identical to the emailSignInPageTitle, which can be redundant. A distinct, action-oriented translation, such as 'أدخل بريدك الإلكتروني' (Enter Your Email), would improve clarity.
"requestCodePageHeadline": "أدخل بريدك الإلكتروني",
| "@emailSignInPageTitle": { | ||
| "description": "Title for the email sign-in page" | ||
| }, | ||
| "requestCodePageHeadline": "Sign in or create an account", | ||
| "requestCodePageHeadline": "Secure Email Sign-In", |
There was a problem hiding this comment.
The requestCodePageHeadline is identical to emailSignInPageTitle, which can be redundant. A distinct, action-oriented headline, such as 'Enter Your Email', would improve the user experience.
"requestCodePageHeadline": "Enter Your Email",
Status
READY/IN DEVELOPMENT/HOLD
Description
Type of Change