-
Notifications
You must be signed in to change notification settings - Fork 0
Fix crud data fetch sorting #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add descending sort by 'updatedAt' field to headlines, topics, and sources repository read operations - This ensures that the most recently updated items are displayed first when fetching data
- Replace HeadlineUpdated event with LoadHeadlinesRequested event - Add const keyword for LoadHeadlinesRequested event
- Replace TopicUpdated event with LoadTopicsRequested event after successful topic update - Ensure topic list is refreshed to reflect changes
- Replace SourceUpdated event with LoadSourcesRequested event - Ensure the source list is refreshed after successful update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug related to data sorting in CRUD operations. I've introduced a default sorting order for fetched content (headlines, topics, and sources) to ensure they are presented by their last update time. Additionally, I've refined the post-update logic to trigger a full data refresh, which helps maintain data consistency and correctly applies the new sorting after an item has been modified.
Highlights
- Data Fetch Sorting: I've implemented a default sorting mechanism for
readAll
operations within theContentManagementBloc
. Headlines, topics, and sources will now be fetched sorted by theirupdatedAt
timestamp in descending order, ensuring the most recently updated items appear first. - Post-Update Data Consistency: After successfully updating a headline, topic, or source, the application will now trigger a full reload of the respective list. This replaces the previous behavior of only updating the single item in the UI, ensuring that the displayed data is consistent with the backend and reflects the new sorting order.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an issue with data sorting by adding a sort option to the data fetching calls. The subsequent change to reload the data after an edit, instead of updating in-place, is also the right approach to maintain the correct sort order in the UI.
I've added a few suggestions to improve maintainability:
- Replace magic strings for the sort key with a constant.
- Remove the now-unused event handlers for
...Updated
events, which have become dead code as a result of these changes.
Once these points are addressed, the PR should be in great shape.
Status
READY/IN DEVELOPMENT/HOLD
Description
Type of Change