Fix data getch sorting #37
Conversation
- Change headlines sort option from 'createdAt' to 'updatedAt' - This ensures that the most recently updated headlines appear first
- Implement ascending sort by name for sources, topics, and countries - Update readAll() calls in Future.wait to include sorting option
…y name - When loading sources, topics, and countries for the edit headline form, the lists are now sorted alphabetically by name in ascending order. - This change improves the user experience by providing a consistent and predictable order for these lists in the application.
- Modify the readAll() method in the countries repository to include sorting by name in ascending order - Update made in the create_source_bloc.dart file
…ing source - Modify the `edit_source_bloc.dart` file to include sorting when fetching countries - Use `SortOption` to sort countries by 'name' in ascending order - Improve user experience by presenting a consistent and organized list of countries
- Change sorting option from 'name' to 'updatedAt' for sources, topics, and countries in CreateHeadlineBloc, EditHeadlineBloc, CreateSourceBloc, and EditSourceBloc - This change affects multiple files and blocs in the content_management feature
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily addresses data sorting inconsistencies across various data fetching operations within the content management and dashboard modules. My changes ensure that lists of sources, topics, and countries are consistently sorted by their updatedAt timestamp in ascending order when fetched for creation or editing forms. Additionally, the dashboard's headline display now prioritizes headlines based on their updatedAt timestamp in descending order, providing a more current view.
Highlights
- Consistent Data Sorting: I've updated the
readAll()calls for_sourcesRepository,_topicsRepository, and_countriesRepositoryinCreateHeadlineBloc,CreateSourceBloc,EditHeadlineBloc, andEditSourceBlocto include asortparameter. This ensures that fetched data for these entities is consistently ordered byupdatedAtin ascending order, providing a predictable and logical sequence for display or processing. - Dashboard Headline Sorting: The sorting logic for headlines displayed on the dashboard has been adjusted. Previously sorted by
createdAt, headlines are now sorted byupdatedAtin descending order. This change aims to present the most recently updated headlines prominently on the dashboard, which is often a more relevant metric for 'latest' content.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors data fetching logic across several BLoCs to sort by updatedAt. The changes are logical and consistently applied. My review focuses on improving maintainability by addressing code duplication and the use of magic strings.
Status
READY/IN DEVELOPMENT/HOLD
Description
Type of Change