fix(content_management): update sort order to descending for reposito… #38
Conversation
…ry reads - Change sort order from ascending to descending for readAll operations in multiple repositories - Update affected BLoCs: CreateHeadline, CreateSource, EditHeadline, EditSource - Modify sort parameter in readAll methods for sources, topics, and countries repositories
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug in the content management system by reversing the default sort order for data retrieval operations. Previously, data was fetched in ascending order based on updatedAt, but this change ensures that the most recently updated items are now returned first, improving the user experience when creating or editing content.
Highlights
- Bug Fix: Corrected an issue where
readAlloperations in several content management repositories were sorting data in ascending order, which was not the desired behavior for displaying the most recent items. - Sort Order Change: Updated the
sortparameter forreadAllcalls on_sourcesRepository,_topicsRepository, and_countriesRepositorytoSortOrder.desc. - Affected BLoCs: Applied the sort order change across
CreateHeadlineBloc,CreateSourceBloc,EditHeadlineBloc, andEditSourceBlocto ensure consistent data retrieval and display.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
| @@ -52,13 +52,13 @@ class CreateHeadlineBloc | |||
| countriesResponse, | |||
| ] = await Future.wait([ | |||
| _sourcesRepository.readAll( | |||
| sort: [const SortOption('updatedAt', SortOrder.asc)], | |||
| sort: [const SortOption('updatedAt', SortOrder.desc)], | |||
There was a problem hiding this comment.
Consider defining a constant for the sort option to improve maintainability and prevent potential typos. Using a named constant, such as const defaultSort = [SortOption('updatedAt', SortOrder.desc)];, can enhance code clarity.
| @@ -39,7 +39,7 @@ class CreateSourceBloc extends Bloc<CreateSourceEvent, CreateSourceState> { | |||
| emit(state.copyWith(status: CreateSourceStatus.loading)); | |||
| try { | |||
| final countriesResponse = await _countriesRepository.readAll( | |||
| sort: [const SortOption('updatedAt', SortOrder.asc)], | |||
| sort: [const SortOption('updatedAt', SortOrder.desc)], | |||
There was a problem hiding this comment.
Consider defining a constant for the sort option to improve maintainability and prevent potential typos. Using a named constant, such as const defaultSort = [SortOption('updatedAt', SortOrder.desc)];, can enhance code clarity.
| @@ -54,13 +54,13 @@ class EditHeadlineBloc extends Bloc<EditHeadlineEvent, EditHeadlineState> { | |||
| ] = await Future.wait([ | |||
| _headlinesRepository.read(id: _headlineId), | |||
| _sourcesRepository.readAll( | |||
| sort: [const SortOption('updatedAt', SortOrder.asc)], | |||
| sort: [const SortOption('updatedAt', SortOrder.desc)], | |||
There was a problem hiding this comment.
Consider defining a constant for the sort option to improve maintainability and prevent potential typos. Using a named constant, such as const defaultSort = [SortOption('updatedAt', SortOrder.desc)];, can enhance code clarity.
| @@ -43,7 +43,7 @@ class EditSourceBloc extends Bloc<EditSourceEvent, EditSourceState> { | |||
| final [sourceResponse, countriesResponse] = await Future.wait([ | |||
| _sourcesRepository.read(id: _sourceId), | |||
| _countriesRepository.readAll( | |||
| sort: [const SortOption('updatedAt', SortOrder.asc)], | |||
| sort: [const SortOption('updatedAt', SortOrder.desc)], | |||
There was a problem hiding this comment.
Consider defining a constant for the sort option to improve maintainability and prevent potential typos. Using a named constant, such as const defaultSort = [SortOption('updatedAt', SortOrder.desc)];, can enhance code clarity.
…ry reads
Status
READY/IN DEVELOPMENT/HOLD
Description
Type of Change