Fix content management malfunxtionned countries & languages dropdown #44
Conversation
Refactored `SearchableDropdownFormField` to make it a fully reactive component that rebuilds its internal search dialog based on the state of a provided BLoC. - Made the widget generic over BLoC and State types (`<T, B extends BlocBase<S>, S>`). - Replaced static `items`, `hasMore`, and `isLoading` parameters with constructor-injected "extractor" functions (`itemsExtractor`, `hasMoreExtractor`, `isLoadingExtractor`). These functions derive the necessary data from the BLoC's state. - The internal `_SearchableSelectionDialog` now uses a `BlocBuilder` to listen for state changes from the provided BLoC, ensuring the list of items and loading indicators are always up-to-date.
Refactored the `create_headline_page.dart` to use the new BLoC-aware `SearchableDropdownFormField` for country selection. - Replaced the old dropdown implementation with the new generic `SearchableDropdownFormField<Country, CreateHeadlineBloc, CreateHeadlineState>`. - Injected the `CreateHeadlineBloc` instance into the widget. - Provided extractor functions (`itemsExtractor`, `hasMoreExtractor`, `isLoadingExtractor`) to enable the dropdown to reactively pull data from the BLoC's state. This change ensures that the country list in the search dialog updates automatically when more items are loaded via pagination, fixing the core UI refresh bug.
Refactored the `edit_headline_page.dart` to use the new BLoC-aware `SearchableDropdownFormField` for country selection. - Replaced the old dropdown implementation with the new generic `SearchableDropdownFormField<Country, EditHeadlineBloc, EditHeadlineState>`. - Injected the `EditHeadlineBloc` instance into the widget. - Provided extractor functions (`itemsExtractor`, `hasMoreExtractor`, `isLoadingExtractor`) to enable the dropdown to reactively pull data from the BLoC's state. This change ensures that the country list in the search dialog updates automatically when more items are loaded via pagination, fixing the core UI refresh bug.
Refactored the `create_source_page.dart` to use the new BLoC-aware `SearchableDropdownFormField` for both language and country selection. - Replaced the old dropdown implementations with the new generic `SearchableDropdownFormField`. - Injected the `CreateSourceBloc` instance into each widget. - Provided extractor functions (`itemsExtractor`, `hasMoreExtractor`, `isLoadingExtractor`) to enable the dropdowns to reactively pull the correct data (languages or countries) from the BLoC's state. This change ensures that both the language and country lists in their respective search dialogs update automatically when more items are loaded via pagination.
Refactored the `edit_source_page.dart` to use the new BLoC-aware `SearchableDropdownFormField` for both language and country selection. - Replaced the old dropdown implementations with the new generic `SearchableDropdownFormField`. - Injected the `EditSourceBloc` instance into each widget. - Provided extractor functions (`itemsExtractor`, `hasMoreExtractor`, `isLoadingExtractor`) to enable the dropdowns to reactively pull the correct data (languages or countries) from the BLoC's state. This change ensures that both the language and country lists in their respective search dialogs update automatically when more items are loaded via pagination, completing the bug fix.
fulleni
deleted the
fix-content-management-malfunxtionned-countries-&-languages-dropdown
branch
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a malfunction in content management dropdowns by refactoring the core SearchableDropdownFormField widget to be BLoC-aware. This change streamlines how country and language selection dropdowns handle data, loading states, and pagination, leading to more robust and reactive UI components across the application's content management forms.
Highlights
- BLoC Integration for Dropdowns: The
SearchableDropdownFormFieldwidget has been refactored to directly integrate with BLoC state management. It now accepts a BLoC instance and extractor functions to retrieve items, pagination status (hasMore), and loading status (isLoading) from the BLoC's state, rather than receiving these properties directly. - Improved Dialog State Management: The internal
_SearchableSelectionDialogused by theSearchableDropdownFormFieldhas also been updated to be BLoC-aware, ensuring that the dialog's content and loading indicators are dynamically updated based on the BLoC's state. - Application of New API: The updated
SearchableDropdownFormFieldAPI has been applied across various content management pages, specifically for country and language selection dropdowns inCreateHeadlinePage,CreateSourcePage,EditHeadlinePage, andEditSourcePage. - Refined Loading Indicator Logic: The logic for displaying the loading indicator within the dropdown's list has been improved to ensure it only appears when there are more items to load and the data is actively being fetched.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This PR refactors the SearchableDropdownFormField to be driven by a BLoC, which is a great improvement for state management within the dialog. The implementation of the widget itself is solid.
However, I've found a significant issue with how the loading state is determined in all instances where the new widget is used. The isLoadingExtractor is tied to a page-level loading status, which prevents the search and pagination loading indicators from ever being displayed. I've left detailed comments on how to address this.
Also, a minor typo in the PR title: "malfunxtionned" should be "malfunctioned".
Status
READY/IN DEVELOPMENT/HOLD
Description
Type of Change