Enhance data fetching mechanism #49
Conversation
- Add loading indicator for language and country lists - Disable dropdowns when loading more items - Display helper text when lists are loading
- Add helper text to show loading status in country dropdown - Disable country selection when more countries are being loaded
… when fetching items - Add helper text and disable onChanged callback for language dropdown when loading more languages - Add helper text and disable onChanged callback for country dropdown when loading more countries - Improve user experience by indicating when the full list is being loaded
- Add new localization string 'loadingFullList' in AppLocalizationsAr class - Translation: 'جاري تحميل القائمة الكاملة...'
- Add new localization string 'loadingFullList' to AppLocalizationsEn class - This string can be used in the UI to indicate that a complete list is being loaded
- Add new localization string 'loadingFullList' for displaying a message in dropdowns when their full list of items is being loaded in the background. - This new string will improve user experience by providing feedback when large datasets are being processed.
- Add new translation key "loadingFullList" for Arabic and English - Include description for the new key in both language files - Message indicates that the full list of items in a dropdown is being loaded
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've enhanced the data fetching mechanism within the application's forms, specifically for dropdown fields. This change introduces visual feedback to users when a dropdown's options are still being loaded in the background, displaying a "Loading full list..." message. Additionally, it prevents users from interacting with these dropdowns while the data fetching is in progress, improving the user experience and preventing potential issues from premature selection.
Highlights
- User Interface Feedback: Implemented helperText in InputDecoration for language, headquarters, and country dropdowns across CreateSourcePage, EditHeadlinePage, and EditSourcePage. This text dynamically displays "Loading full list..." when the associated data is being fetched.
- User Interaction Control: Disabled the onChanged callback for these dropdowns while their respective data lists are loading, ensuring users cannot select an option from an incomplete list.
- Internationalization: Added a new localization key loadingFullList with English and Arabic translations to support the new loading helper text.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to improve the data fetching mechanism by showing a loading indicator and disabling dropdowns while fetching the full list of items. This is a great UX enhancement.
I've found a critical issue across all the updated screens (CreateSource, EditHeadline, EditSource): the BLoC logic that should drive the new loading indicators is incomplete. The flags like languagesIsLoadingMore and countriesIsLoadingMore are used in the UI but are never set to true in the corresponding BLoCs. This means the loading indicators will never be shown to the user. I've left specific comments on the affected UI components with more details.
The localization changes look good.
Once the BLoC logic is fixed, this will be a solid improvement.
Status
READY/IN DEVELOPMENT/HOLD
Description
Type of Change