Sync the dashbaord with the core models change #62
Conversation
- Replace hardcoded 'en' language with dynamic initialization using language fixtures - Improve error handling by throwing StateError if default language is not found - Refactor display settings initialization for better readability
- Update locale setting to use language.code instead of just language - This ensures proper locale initialization when the app is restarted
- Replace hardcoded 'en' language code with a safer initialization method - Use fixtures data to find the default language, throwing an error if not found - Add comments to explain the logic for handling missing settings
- Change SettingsLanguageChanged.language type from AppLanguage to Language - Update props list to reflect the new type
- Remove ExpansionTile for feed actions configuration - Delete _buildAccountActionConfigSection method - Add const SizedBox.shrink() as a placeholder
…idget - Delete the entire _AccountActionConfigForm StatefulWidget and its associated _AccountActionConfigFormState class - This widget was likely unused and not contributing to the functionality of the app
- Implement new UI section for configuring feed decorators - Add ExpansionTile for each feed decorator type - Include form fields for enabling/disabling decorators, items to display, and role-specific settings - Update RemoteConfig with new feed decorator configurations - Ensure proper state management and data binding for form inputs
- Update resolved-ref from 0da5bb6 to 55f27de
- Replace custom AppLanguage type with Language model - Remove hardcoded supported languages in favor of languagesFixturesData - Simplify language name retrieval using the name property - Remove unnecessary _getLanguageName method
- Add translations for new "Feed Decorators" section - Remove unnecessary descriptions for force update and Android update URL - Update translation for "appStatusOperational" to "يعاري" - Add new translations for undo functionality and related settings
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request synchronizes the application's dashboard and settings with recent changes in core models. Key updates include migrating language handling to a new Language object, refactoring feed configuration from "account actions" to a more generic "feed decorators" system, and updating various localization strings to reflect these changes.
Highlights
- Language Model Migration: The application's language settings and display now utilize a new Language object instead of a simple string, ensuring more robust language management.
- Feed Configuration Overhaul: The AppConfigurationPage has been significantly refactored to introduce a flexible "Feed Decorators" section, replacing the previous "Account Actions" setup. This new section allows for detailed configuration of how content is presented in the feed, including enabling/disabling decorators, setting item display limits, and defining role-specific visibility.
- Internationalization Updates: New localization keys and updated descriptions have been added to support the new "Feed Decorators" terminology and provide clearer text for force update settings.
- Dependency Upgrades: Several core dependencies have been updated to their latest versions, and a new mime package has been introduced, ensuring the project uses up-to-date libraries.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request synchronizes the dashboard with changes in the core models, primarily by replacing "Account Actions" with "Feed Decorators" and updating language handling to use a Language model object. The changes are extensive, touching UI, BLoC, and localization files. My review focuses on improving code maintainability by reducing duplication, fixing a bug in form field handling, and correcting a translation error. I've also noted a potential inconsistency in the localization file management.
Status
READY/IN DEVELOPMENT/HOLD
Description
Type of Change