fix: prevent focus loop in PaymentElement widget#2022
Merged
remonh87 merged 2 commits intoflutter-stripe:mainfrom Jan 18, 2025
Merged
fix: prevent focus loop in PaymentElement widget#2022remonh87 merged 2 commits intoflutter-stripe:mainfrom
remonh87 merged 2 commits intoflutter-stripe:mainfrom
Conversation
Removed prints.
remonh87
approved these changes
Jan 2, 2025
Member
remonh87
left a comment
remonh87
left a comment
There was a problem hiding this comment.
Looks good can you check my comment else we can integrate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue where the
PaymentElementwidget from theflutter_stripe_webpackage repeatedly toggles focus when an input field is selected, causing the input to lose focus. This issue occurred due to a feedback loop of focus/blur events.Changes Made:
_isManuallyFocusing,_isCurrentlyFocused) to prevent focus/blur recursion.element?.focus()andelement?.blur()based on the new conditions.Testing:
PaymentElementinput fields retain focus and the focus state toggling issue is resolved.Screen.Recording.2024-12-23.at.23.59.42.mov
Fixes #2021