Skip to content

Exception in _handleCardChanged #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uristrimber wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Exception in _handleCardChanged #2265

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79cd843
Update card_field.dart
uristrimber Nov 17, 2025
3030e78
Rename project from stripe_workspace to flutter_stripe_fork
uristrimber Nov 17, 2025
d8e5e3f
Rename package from flutter_stripe_fork to stripe_workspace
uristrimber Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/stripe/lib/src/widgets/card_field.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,9 +541,7 @@ class _MethodChannelCardFieldState extends State<_MethodChannelCardField>
void _handleCardChanged(dynamic arguments) {
try {
final map = Map<String, dynamic>.from(arguments);
final update = CardFieldInputDetails.fromJson(
Map<String, dynamic>.from(map['card']),
Copy link
Member

@remonh87 remonh87 Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this nesting is still necesarry tested it with latest sdk on android

Copy link
Author

@uristrimber uristrimber Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the map doesn't have the 'card' value, it creates an exception and crashes.

Copy link
Author

@uristrimber uristrimber Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the UI works for you?.
We had to fork the package in PROD as it was throwing an eception

Copy link
Member

@remonh87 remonh87 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested both android and ios and for the ui works. Can you give me some more details of the version of the package that you are using?

Copy link
Author

@uristrimber uristrimber Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I've been very busy, I'll send a demo ASAP.

Copy link
Author

@uristrimber uristrimber Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Author

@uristrimber uristrimber Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

card is not a valid value in the map

Copy link
Author

@uristrimber uristrimber Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

It keeps the pay button in grey button as the issue throws the exception

);
final update = CardFieldInputDetails.fromJson(map);
updateCardDetails(update, controller);
widget.onCardChanged?.call(update);
// ignore: avoid_catches_without_on_clauses
Expand Down