Unified Check Run flow implementation #4906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck Run Flow - Updated `GithubChecksService` to use the new `isTaskFailed` method for checking task failure. - Removed the deprecated `taskFailed` method from `GithubChecksService`. - Modified `LuciBuildService` to support unified check run flow, including changes to method signatures and logic for scheduling builds. - Enhanced `PresubmitUserData` to include optional fields for guard check run ID and stage. - Updated JSON serialization for `PresubmitUserData` to handle new fields. - Refactored `Scheduler` to integrate unified check run logic, including changes to document initialization and task scheduling. - Adjusted tests to reflect changes in method signatures and logic, ensuring proper mocking and verification.
jtmcdole
reviewed
Jan 8, 2026
| build.summaryMarkdown = (await _luciBuildService.getBuildById( | ||
| build.id, | ||
| buildMask: bbv2.BuildMask( | ||
| // Need to use allFields as there is a bug with fieldMask and summaryMarkdown. |
Member
There was a problem hiding this comment.
bug with our implementation or somewhere is? issue tracking id?
Comment on lines
+140
to
+141
| if (!rescheduled && config.flags.closeMqGuardAfterPresubmit || | ||
| !rescheduled && userData.guardCheckRunId != null) { |
Member
There was a problem hiding this comment.
Thoughts on:
final hasGuardCheckRunId = userData.guardCheckRunId != null;
if (!rescheduled && (config.flags.closeMqGuardAfterPresubmit || hasGuardCheckRunId))
and then later:
id: hasGuardCheckRunId ? userData.guardCheckRunId! | userData.checkRunId,
name: hasGuardCheckRunId ? 'Merge Queue Guard' | builderName,
Comment on lines
+23
to
30
| import '../model/common/presubmit_check_state.dart'; | ||
| import '../model/common/presubmit_guard_conclusion.dart'; | ||
| import '../model/firestore/base.dart'; | ||
| import '../model/firestore/ci_staging.dart'; | ||
| import '../model/firestore/commit.dart' as fs; | ||
| import '../model/firestore/pr_check_runs.dart'; | ||
| import '../model/firestore/presubmit_guard.dart'; | ||
| import '../model/firestore/task.dart' as fs; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor GitHub Checks Service and Luci Build Service for Unified Check Run Flow
GithubChecksServiceto use the newisTaskFailedmethod for checking task failure.taskFailedmethod fromGithubChecksService.LuciBuildServiceto support unified check run flow, including changes to method signatures and logic for scheduling builds.PresubmitUserDatato include optional fields for guard check run ID and stage.PresubmitUserDatato handle new fields.Schedulerto integrate unified check run logic, including changes to document initialization and task scheduling.Fixes: flutter/flutter#176981
Fixes: flutter/flutter#176982