Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions app_dart/lib/src/request_handlers/presubmit_luci_subscription.dart
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ final class PresubmitLuciSubscription extends SubscriptionHandler {
return Response.emptyOk;
}

final build = buildsPubSub.build;
var build = buildsPubSub.build;

// Add build fields that are stored in a separate compressed buffer.
build.mergeFromBuffer(ZLibCodec().decode(buildsPubSub.buildLargeFields));
Expand All @@ -104,14 +104,17 @@ final class PresubmitLuciSubscription extends SubscriptionHandler {
var rescheduled = false;
final isUnifiedCheckRun = userData.guardCheckRunId != null;
if (build.status.isTaskFailed()) {
// if failed summary stored in github check run and unified check run.
build.summaryMarkdown = (await _luciBuildService.getBuildById(
build.id,
buildMask: bbv2.BuildMask(
// Need to use allFields as there is a bug with fieldMask and summaryMarkdown.
allFields: true,
),
)).summaryMarkdown;
if (isUnifiedCheckRun) {
// If failed we need summaryMarkdown. For github check run flow this
// called in [GithubChecksService.updateCheckStatus(...)]
build = await _luciBuildService.getBuildById(
build.id,
buildMask: bbv2.BuildMask(
// Need to use allFields as there is a bug with fieldMask and summaryMarkdown.
allFields: true,
),
);
}
final maxAttempt = await _getMaxAttempt(
userData.commit,
builderName,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ final class UnifiedCheckRunFlow {
);

/// Whether to use unified check-run flow with only one check-run created
/// for all LUCI tests or legacy check-run flow.
/// for all LUCI tests or github check-run flow.
@JsonKey()
final bool useForAll;

Expand Down
2 changes: 1 addition & 1 deletion app_dart/lib/src/service/scheduler.dart
Original file line number Diff line number Diff line change
Expand Up @@ -948,7 +948,7 @@ $s
if (kCheckRunsToIgnore.contains(check.name)) {
return true;
}
final flow = check.isUnifiedCheckRun ? 'unified' : 'legacy';
final flow = check.isUnifiedCheckRun ? 'unified' : 'github';
final requestor = check.isMergeGroup ? 'merge group' : 'pull request';
final logCrumb =
'checkCompleted(${check.name}, $flow, $requestor, ${check.slug}, ${check.sha}, ${check.status})';
Expand Down
Loading