fix: suppressed issue link getting overridden

app_dart/lib/src/request_handlers/update_suppressed_test.dart

@@ -23,6 +23,7 @@ import '../service/firestore.dart';
 /// - `repository`: The repository slug (e.g. `flutter/flutter`).
 /// - `action`: `SUPPRESS` or `UNSUPPRESS`.
 /// - `issueLink`: URL to the GitHub issue tracking the failure.
+///    required if SUPPRESS
 /// - `note`: Optional note describing the action.
 final class UpdateSuppressedTest extends ApiRequestHandler {
   const UpdateSuppressedTest({
@@ -75,13 +76,6 @@ final class UpdateSuppressedTest extends ApiRequestHandler {
       );
     }
 
-    final issueLink = body[_paramIssueLink];
-    if (issueLink is! String) {
-      throw const BadRequestException(
-        'Parameter "$_paramIssueLink" must be a string',
-      );
-    }
-
     final RepositorySlug repository;
     {
       final repositoryString = body[_paramRepository];
@@ -100,16 +94,26 @@ final class UpdateSuppressedTest extends ApiRequestHandler {
       );
     }
 
-    // Validate issue link
-    final issueNumber = _parseIssueNumber(issueLink);
-    if (issueNumber == null) {
-      throw const BadRequestException(
-        'Invalid issue link format, expected https://github.com/flutter/flutter/issues/1234',
-      );
-    }
+    String? issueLink;
 
     // Validate issue exists and is open if suppressing
     if (action == _actionSuppress) {
+      final link = body[_paramIssueLink];
+      if (link is! String) {
+        throw const BadRequestException(
+          'Parameter "$_paramIssueLink" must be a string',
+        );
+      }
+      issueLink = link;
+
+      // Validate issue link
+      final issueNumber = _parseIssueNumber(issueLink);
+      if (issueNumber == null) {
+        throw const BadRequestException(
+          'Invalid issue link format, expected https://github.com/flutter/flutter/issues/1234',
+        );
+      }
+
       final githubService = await config.createGithubService(repository);
       final issue = await githubService.getIssue(
         repository,
@@ -160,8 +164,8 @@ final class UpdateSuppressedTest extends ApiRequestHandler {
     required String testName,
     required RepositorySlug repository,
     required String action,
-    required String issueLink,
     required String note,
+    String? issueLink,
   }) async {
     // Query for existing suppression - we assume there is at most one document
     // per (repo, name) based on business logic, though the DB constraint might
@@ -197,7 +201,8 @@ final class UpdateSuppressedTest extends ApiRequestHandler {
       final updatedSuppression = SuppressedTest(
         name: testName,
         repository: repository.fullName,
-        issueLink: issueLink,
+        // issue: today we don't have UI affordance for updating the link.
+        issueLink: existingSuppression.issueLink,
         isSuppressed: isSuppressed,
         createTimestamp: existingSuppression.createTimestamp,
         updates: [...existingSuppression.updates, updateEntry],
@@ -224,7 +229,7 @@ final class UpdateSuppressedTest extends ApiRequestHandler {
       final newSuppression = SuppressedTest(
         name: testName,
         repository: repository.fullName,
-        issueLink: issueLink,
+        issueLink: issueLink ?? 'BUG',
         isSuppressed: true,
         createTimestamp: now,
         updates: [updateEntry],

app_dart/lib/src/request_handling/static_file_handler.dart

@@ -39,9 +39,7 @@ final class StaticFileHandler extends RequestHandler {
       '.smcbin': 'application/octet-stream',
     };
 
-    const mimeFileMap = {
-     'apple-app-site-association': 'application/json',
-    };
+    const mimeFileMap = {'apple-app-site-association': 'application/json'};
 
     final resultPath = filePath == '/' ? '/index.html' : filePath;
 

app_dart/test/model/firestore/suppressed_test_test.dart

@@ -8,7 +8,6 @@ import 'package:cocoon_service/src/model/firestore/suppressed_test.dart';
 import 'package:googleapis/firestore/v1.dart';
 import 'package:test/test.dart';
 
-
 void main() {
   useTestLoggerPerTest();
 

app_dart/test/request_handlers/presubmit_luci_subscription_test.dart

@@ -60,8 +60,6 @@ void main() {
       ciYaml: examplePresubmitRescheduleFusionConfig,
     );
 
-
-
     handler = PresubmitLuciSubscription(
       cache: CacheService(inMemory: true),
       config: config,

app_dart/test/request_handlers/update_suppressed_test_test.dart

@@ -247,7 +247,7 @@ void main() {
       'testName': 'my_test',
       'repository': 'flutter/flutter',
       'action': 'UNSUPPRESS',
-      'issueLink': 'https://github.com/flutter/flutter/issues/123',
+      'issueLink': 'https://github.com/flutter/flutter/issues/345',
       'note': 'Closing issue',
     });
 

app_dart/test/service/scheduler_test.dart

@@ -3643,10 +3643,7 @@ targets:
 
         final check = PresubmitCompletedCheck.fromBuild(build, userData);
 
-        expect(
-          await scheduler.processCheckRunCompleted(check),
-          isTrue,
-        );
+        expect(await scheduler.processCheckRunCompleted(check), isTrue);
 
         // Should schedule tests for the next stage (fusionTests)
         expect(fakeLuciBuildService.scheduledTryBuilds, isNotEmpty);
@@ -3722,10 +3719,7 @@ targets:
 
           final check = PresubmitCompletedCheck.fromBuild(build, userData);
 
-          expect(
-            await scheduler.processCheckRunCompleted(check),
-            isTrue,
-          );
+          expect(await scheduler.processCheckRunCompleted(check), isTrue);
 
           verify(
             mockGithubChecksUtil.updateCheckRun(
@@ -3810,10 +3804,7 @@ targets:
 
         final check = PresubmitCompletedCheck.fromBuild(build, userData);
 
-        expect(
-          await scheduler.processCheckRunCompleted(check),
-          isTrue,
-        );
+        expect(await scheduler.processCheckRunCompleted(check), isTrue);
 
         verify(
           mockGithubChecksUtil.updateCheckRun(

dashboard/lib/service/appengine_cocoon.dart

@@ -264,20 +264,18 @@ class AppEngineCocoonService implements CocoonService {
     required String repo,
     required String testName,
     required bool suppress,
-    required String issueLink,
+    String? issueLink,
     String? note,
   }) async {
-    final updateTestSuppressionUrl = apiEndpoint(
-      '/api/update-suppressed-test',
-    );
+    final updateTestSuppressionUrl = apiEndpoint('/api/update-suppressed-test');
     final response = await _client.post(
       updateTestSuppressionUrl,
       headers: {'X-Flutter-IdToken': idToken},
       body: jsonEncode({
         'repository': repo,
         'testName': testName,
         'action': suppress ? 'SUPPRESS' : 'UNSUPPRESS',
-        'issueLink': issueLink,
+        'issueLink': ?issueLink,
         'note': ?note,
       }),
     );

dashboard/lib/service/cocoon.dart

@@ -103,7 +103,7 @@ abstract class CocoonService {
     required String repo,
     required String testName,
     required bool suppress,
-    required String issueLink,
+    String? issueLink,
     String? note,
   });
 }

dashboard/lib/service/dev_cocoon.dart

@@ -146,7 +146,7 @@ class DevelopmentCocoonService implements CocoonService {
     required String repo,
     required String testName,
     required bool suppress,
-    required String issueLink,
+    String? issueLink,
     String? note,
   }) async {
     final list = _suppressedTests.putIfAbsent(repo, () => []);
@@ -156,7 +156,8 @@ class DevelopmentCocoonService implements CocoonService {
           SuppressedTest(
             name: testName,
             repository: repo,
-            issueLink: issueLink,
+            issueLink:
+                issueLink ?? 'https://github.com/flutter/flutter/issues/123',
             createTimestamp: DateTime.now().millisecondsSinceEpoch,
             updates: [
               SuppressionUpdate(

dashboard/lib/state/build.dart

@@ -426,7 +426,7 @@ class BuildState extends ChangeNotifier {
   Future<bool> updateTestSuppression({
     required String testName,
     required bool suppress,
-    required String issueLink,
+    String? issueLink,
     String? note,
   }) async {
     if (!authService.isAuthenticated) {

dashboard/lib/widgets/task_grid.dart

@@ -220,8 +220,8 @@ class _TaskGridState extends State<TaskGrid> {
     filter ??= TaskGridFilter();
 
     // Pre-compute suppressed task names for faster lookup
-    final suppressedTaskNames = {
-      for (final s in taskGrid.buildState.suppressedTests) s.name,
+    final suppressedTasks = {
+      for (final s in taskGrid.buildState.suppressedTests) s.name: s,
     };
 
     // 1: PREPARE ROWS
@@ -274,7 +274,7 @@ class _TaskGridState extends State<TaskGrid> {
           // won't know how to sort the task later.
           scores.putIfAbsent(qualifiedTask, () => 0.0);
         }
-        final isSuppressed = suppressedTaskNames.contains(task.builderName);
+        final isSuppressed = suppressedTasks.containsKey(task.builderName);
         rows[commitCount - 1].cells[qualifiedTask] = LatticeCell(
           painter: _painterFor(task, isSuppressed),
           builder: _builderFor(task, isSuppressed),
@@ -286,8 +286,8 @@ class _TaskGridState extends State<TaskGrid> {
     final tasks = scores.keys.toList()
       ..sort((QualifiedTask a, QualifiedTask b) {
         // Suppressed tests go first (far left)
-        final aSuppressed = suppressedTaskNames.contains(a.task);
-        final bSuppressed = suppressedTaskNames.contains(b.task);
+        final aSuppressed = suppressedTasks.containsKey(a.task);
+        final bSuppressed = suppressedTasks.containsKey(b.task);
         if (aSuppressed && !bSuppressed) {
           return -1;
         }
@@ -307,43 +307,29 @@ class _TaskGridState extends State<TaskGrid> {
       <LatticeCell>[
         const LatticeCell(),
         ...tasks.map<LatticeCell>((QualifiedTask task) {
-          final isSuppressed = suppressedTaskNames.contains(task.task);
           return LatticeCell(
             builder: (BuildContext context) {
+              final suppressedTest = suppressedTasks[task.task];
               final icon = TaskIcon(
                 qualifiedTask: task,
-                onTap: () => _showTestDetails(context, task),
+                onTap: (BuildContext context) =>
+                    _showTestDetails(context, task),
               );
-              if (isSuppressed) {
-                final suppressedTest = taskGrid.buildState.suppressedTests
-                    .firstWhere((s) => s.name == task.task);
+              if (suppressedTest != null) {
                 // Format audit log
-                final tip = [
-                  'Issue: ${suppressedTest.issueLink}',
-                  for (var update
-                      in [...suppressedTest.updates]..sort(
-                        (a, b) =>
-                            b.updateTimestamp.compareTo(a.updateTimestamp),
-                      ))
-                    '[${DateTime.fromMillisecondsSinceEpoch(update.updateTimestamp)}] ${update.action} by ${update.user} ${update.note != null ? '- ${update.note}' : ''}',
-                ].join('\n');
-
-                return Tooltip(
-                  message: tip,
-                  child: Stack(
-                    alignment: Alignment.bottomRight,
-                    children: [
-                      Opacity(opacity: 0.3, child: icon),
-                      const IgnorePointer(
-                        child: Icon(
-                          Icons.snooze,
-                          fontWeight: FontWeight.bold,
-                          size: 20,
-                          color: Colors.red,
-                        ),
+                return Stack(
+                  alignment: Alignment.bottomRight,
+                  children: [
+                    Opacity(opacity: 0.3, child: icon),
+                    const IgnorePointer(
+                      child: Icon(
+                        Icons.snooze,
+                        fontWeight: FontWeight.bold,
+                        size: 20,
+                        color: Colors.red,
                       ),
-                    ],
-                  ),
+                    ),
+                  ],
                 );
               }
               return icon;
@@ -510,6 +496,7 @@ class _TaskGridState extends State<TaskGrid> {
     final renderBox = context.findRenderObject() as RenderBox;
     final position = renderBox.localToGlobal(Offset.zero);
 
+    print('_showTestDetails: $position');
     _taskOverlay = OverlayEntry(
       builder: (BuildContext context) => Stack(
         children: <Widget>[

dashboard/lib/widgets/task_icon.dart

@@ -22,7 +22,7 @@ class TaskIcon extends StatelessWidget {
   final QualifiedTask qualifiedTask;
 
   /// Callback when the icon is tapped.
-  final VoidCallback? onTap;
+  final void Function(BuildContext)? onTap;
 
   /// A lookup table for matching [stageName] to [Image].
   ///
@@ -91,7 +91,7 @@ class TaskIcon extends StatelessWidget {
       child: InkWell(
         onTap: () async {
           if (onTap != null) {
-            onTap!();
+            onTap!(context);
           } else {
             await launchUrl(qualifiedTask.sourceConfigurationUrl);
           }