re-run failed tests using check-run re-run failed button
#4922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ievdokdm
added
the
autosubmit
Contributor
|
autosubmit label was removed for flutter/cocoon/4922, because - The status or check suite common-validations has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
ievdokdm
changed the title
re-run failed button
ievdokdm
added
the
autosubmit
jtmcdole
approved these changes
Jan 22, 2026
| /// Contains the list of failed checks that are proposed to be re-run. | ||
| /// | ||
| /// See: [UnifiedCheckRun.reInitializeFailedChecks] | ||
| class FailedChecksForRerun { |
Member
There was a problem hiding this comment.
note to self, i wonder if we should use @freezed here - we don't currently have it as a dependency, so don't treat this as a request for anything.
Comment on lines
+101
to
+104
| final failedBuilds = guard.builds?.entries | ||
| .where((entry) => entry.value.isFailure) | ||
| .map((entry) => entry.key) | ||
| .toList(); |
Member
There was a problem hiding this comment.
this method could be added to the PresubmitGuard to provide a getter for "failedBuilds"
final failedBuilds = [
for (final Map(:key, :value) in guard.builds?.entries)
if (value.isFailure)
key,
];
Comment on lines
+1626
to
+1681
| if (checkRunEvent.requestedAction?.identifier == 're_run_failed') { | ||
| log.info( | ||
| 'Requested to re-run failed tests for ${checkRunEvent.checkRun!.id} check-run id', | ||
| ); | ||
| // The CheckRunEvent.checkRun.pullRequests array is empty for this | ||
| // event, so we need to find the matching pull request. | ||
| final slug = checkRunEvent.repository!.slug(); | ||
| final headSha = checkRunEvent.checkRun!.headSha!; | ||
| final checkSuiteId = checkRunEvent.checkRun!.checkSuite!.id!; | ||
| final pullRequest = await _githubChecksService | ||
| .findMatchingPullRequest(slug, headSha, checkSuiteId); | ||
|
|
||
| final failedChecks = await UnifiedCheckRun.reInitializeFailedChecks( | ||
| firestoreService: _firestore, | ||
| slug: slug, | ||
| pullRequestId: pullRequest!.number!, | ||
| checkRunId: checkRunEvent.checkRun!.id!, | ||
| ); | ||
|
|
||
| if (failedChecks == null) { | ||
| log.error( | ||
| 'No failed targets found for ${checkRunEvent.checkRun!.id} check-run id', | ||
| ); | ||
| return ProcessCheckRunResult.missingEntity( | ||
| 'No failed targets found for ${checkRunEvent.checkRun!.id} check-run id', | ||
| ); | ||
| } | ||
|
|
||
| final (targets, artifacts) = await _getAllTargetsForPullRequest( | ||
| slug, | ||
| pullRequest, | ||
| ); | ||
|
|
||
| final failedTargets = targets | ||
| .where((target) => failedChecks.checkNames.contains(target.name)) | ||
| .toList(); | ||
| if (failedTargets.length != failedChecks.checkNames.length) { | ||
| log.error('Failed to find all failed targets in presubmit targets'); | ||
| return const ProcessCheckRunResult.missingEntity( | ||
| 'Failed to find all failed targets in presubmit targets', | ||
| ); | ||
| } | ||
|
|
||
| await _luciBuildService.scheduleTryBuilds( | ||
| targets: failedTargets, | ||
| pullRequest: pullRequest, | ||
| engineArtifacts: artifacts, | ||
| checkRunGuard: failedChecks.checkRunGuard, | ||
| stage: failedChecks.stage, | ||
| ); | ||
| } else { | ||
| log.warn( | ||
| 'Requested unexpected action: ${checkRunEvent.requestedAction?.identifier} for ${checkRunEvent.checkRun!.id} check-run id', | ||
| ); | ||
| } | ||
| break; |
Member
There was a problem hiding this comment.
you could move this out to a "_reRunFailed" and then we could just:
switch (checkRunEvent.requestedAction?.identifier) {
case 're_run_failed':
_reRunFailed(pr);
default:
log.warn(
'Requested unexpected action: ${checkRunEvent.requestedAction?.identifier} for ${checkRunEvent.checkRun!.id} check-run id',
);
}
jtmcdole
approved these changes
Jan 22, 2026
Merged
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 22, 2026
implemented comments from: #4922 Fixes: flutter/flutter#181334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-run failed tests using check-run
re-run failedbutton added toMerge Queue Guardcheck-run when tests failed andMerge Queue Guardcheck-runconclusionchanged toaction_requiredon git-hub UIGitHub API used:
https://docs.github.com/en/rest/guides/using-the-rest-api-to-interact-with-checks?apiVersion=2022-11-28#check-runs-and-requested-actions
https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=requested_action#check_run
Fixes: flutter/flutter#181334