Skip to content

Fix audio_soloud codelab #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Fix audio_soloud codelab #2251

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
852f32f
Merge remote-tracking branch 'upstream/main'
filiph Oct 16, 2024
983a29b
Increase deployment targets for iOS and macOS
filiph Oct 16, 2024
4eeb5bf
Rerun codelab build and uncomment audio_soloud in CI
filiph Oct 17, 2024
6fa7a95
Update to version of flutter_soloud that’s guaranteed to work
filiph Oct 18, 2024
7c9df89
Upgrade from deprecated members
filiph Oct 18, 2024
ba5f61a
Re-run codelab_rebuild
filiph Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions audio_soloud/codelab_rebuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,32 @@ steps:
path: audio_soloud
flutter: pub upgrade --major-versions

- name: Update iOS deployment target
path: audio_soloud/ios/Podfile
patch-u: |
--- b/audio_soloud/ios/Podfile
+++ a/audio_soloud/ios/Podfile
@@ -1,5 +1,5 @@
-# Uncomment this line to define a global platform for your project
-# platform :ios, '12.0'
+# SoLoud requires iOS 13.0 minimum, Flutter only requires 12.0
+platform :ios, '13.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

- name: Update macOS deployment target
path: audio_soloud/macos/Podfile
patch-u: |
--- b/audio_soloud/macos/Podfile
+++ a/audio_soloud/macos/Podfile
@@ -1,4 +1,4 @@
-platform :osx, '10.14'
+platform :osx, '10.15'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'

- name: Create lib/audio directory
mkdir: audio_soloud/lib/audio

Expand Down
4 changes: 2 additions & 2 deletions audio_soloud/step_02/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Uncomment this line to define a global platform for your project
# platform :ios, '12.0'
# SoLoud requires iOS 13.0 minimum, Flutter only requires 12.0
platform :ios, '13.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
2 changes: 1 addition & 1 deletion audio_soloud/step_02/macos/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :osx, '10.14'
platform :osx, '10.15'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
4 changes: 2 additions & 2 deletions audio_soloud/step_03/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Uncomment this line to define a global platform for your project
# platform :ios, '12.0'
# SoLoud requires iOS 13.0 minimum, Flutter only requires 12.0
platform :ios, '13.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
2 changes: 1 addition & 1 deletion audio_soloud/step_03/macos/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :osx, '10.14'
platform :osx, '10.15'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
4 changes: 2 additions & 2 deletions audio_soloud/step_04a/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Uncomment this line to define a global platform for your project
# platform :ios, '12.0'
# SoLoud requires iOS 13.0 minimum, Flutter only requires 12.0
platform :ios, '13.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
2 changes: 1 addition & 1 deletion audio_soloud/step_04a/macos/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :osx, '10.14'
platform :osx, '10.15'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
4 changes: 2 additions & 2 deletions audio_soloud/step_04b/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Uncomment this line to define a global platform for your project
# platform :ios, '12.0'
# SoLoud requires iOS 13.0 minimum, Flutter only requires 12.0
platform :ios, '13.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
2 changes: 1 addition & 1 deletion audio_soloud/step_04b/macos/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :osx, '10.14'
platform :osx, '10.15'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
4 changes: 2 additions & 2 deletions audio_soloud/step_05/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Uncomment this line to define a global platform for your project
# platform :ios, '12.0'
# SoLoud requires iOS 13.0 minimum, Flutter only requires 12.0
platform :ios, '13.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
2 changes: 1 addition & 1 deletion audio_soloud/step_05/macos/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :osx, '10.14'
platform :osx, '10.15'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
4 changes: 2 additions & 2 deletions audio_soloud/step_06/ios/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Uncomment this line to define a global platform for your project
# platform :ios, '12.0'
# SoLoud requires iOS 13.0 minimum, Flutter only requires 12.0
platform :ios, '13.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
2 changes: 1 addition & 1 deletion audio_soloud/step_06/macos/Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :osx, '10.14'
platform :osx, '10.15'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Expand Down
3 changes: 1 addition & 2 deletions flutter_ci_script_beta.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ declare -a CODELABS=(
"adaptive_app"
"animated-responsive-layout"
"animations"
# TODO(filiph): Re-enable this when the codelab is fixed.
# "audio_soloud"
"audio_soloud"
"boring_to_beautiful"
"brick_breaker"
"dart-patterns-and-records"
Expand Down
3 changes: 1 addition & 2 deletions flutter_ci_script_master.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ declare -a CODELABS=(
"adaptive_app"
"animated-responsive-layout"
"animations"
# TODO(filiph): Re-enable this when the codelab is fixed.
# "audio_soloud"
"audio_soloud"
"boring_to_beautiful"
"brick_breaker"
"dart-patterns-and-records"
Expand Down
3 changes: 1 addition & 2 deletions flutter_ci_script_stable.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ declare -a CODELABS=(
"adaptive_app"
"animated-responsive-layout"
"animations"
# TODO(filiph): Re-enable this when the codelab is fixed.
# "audio_soloud"
"audio_soloud"
"boring_to_beautiful"
"brick_breaker"
"dart-patterns-and-records"
Expand Down
Loading