Skip to content

Conversation

@domesticmouse
Copy link
Contributor

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the colorist codelab to support Riverpod 3. The changes primarily involve updating dependencies in pubspec.yaml files, regenerating provider files (.g.dart) with the new syntax, and updating the application code to use the new provider names.

The migration is mostly correct, but I've found a critical issue in two of the codelab steps (step_06 and step_07) where an incorrect import for flutter_riverpod/legacy.dart has been introduced. This will cause the build to fail for those steps. The import is not only incorrect but also unnecessary, as the required Ref type is already provided by the riverpod_annotation package. My review includes suggestions to remove these erroneous imports.

Other than this issue, the dependency updates and code modifications appear to be correct and consistent with the Riverpod 3 migration guide.

@domesticmouse
Copy link
Contributor Author

Ahh, GenAI. The statement that the legacy imports are incorrect, is incorrect.

@domesticmouse
Copy link
Contributor Author

The CI for this will turn green once #2348 lands and is merged into this PR

@domesticmouse domesticmouse merged commit 186efe1 into flutter:main Sep 13, 2025
10 checks passed
@domesticmouse domesticmouse deleted the update-colorist branch September 13, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants