-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Update colorist for Riverpod 3
#2347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the colorist codelab to support Riverpod 3. The changes primarily involve updating dependencies in pubspec.yaml files, regenerating provider files (.g.dart) with the new syntax, and updating the application code to use the new provider names.
The migration is mostly correct, but I've found a critical issue in two of the codelab steps (step_06 and step_07) where an incorrect import for flutter_riverpod/legacy.dart has been introduced. This will cause the build to fail for those steps. The import is not only incorrect but also unnecessary, as the required Ref type is already provided by the riverpod_annotation package. My review includes suggestions to remove these erroneous imports.
Other than this issue, the dependency updates and code modifications appear to be correct and consistent with the Riverpod 3 migration guide.
|
Ahh, GenAI. The statement that the legacy imports are incorrect, is incorrect. |
|
The CI for this will turn green once #2348 lands and is merged into this PR |
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-devrel channel on Discord.