Skip to content

Conversation

@domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented Oct 22, 2025

The @experimental issue with audio_soloud should now be fixed.

Context: #2350

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables the audio_soloud codelab in the CI by uncommenting it in the CI script and updating the Dart SDK and flutter_soloud dependency versions across all steps of the codelab. The changes are straightforward and correctly implement the intended goal. I have one suggestion regarding dependency management to improve long-term maintainability by reducing duplication across the multiple pubspec.yaml files.

@domesticmouse domesticmouse merged commit 4bb9845 into main Oct 23, 2025
10 checks passed
@domesticmouse domesticmouse deleted the re-enable-soloud-codelab branch October 23, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants