Skip to content

Conversation

@jwren
Copy link
Member

@jwren jwren commented Jul 17, 2025

No description provided.

@jwren jwren requested a review from helin24 July 18, 2025 00:02
@jwren jwren requested a review from pq July 21, 2025 17:17
@pq
Copy link
Collaborator

pq commented Jul 21, 2025

Looks like you need to add some exception handling to DartRemoteDebugConfiguration?

  /home/runner/work/dart-intellij-third-party/dart-intellij-third-party/third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/server/DartRemoteDebugConfiguration.java:61: error: unreported exception CloneNotSupportedException; must be caught or declared to be thrown
      clone.myParameters = myParameters.clone();

@jwren
Copy link
Member Author

jwren commented Jul 21, 2025

Looks like you need to add some exception handling to DartRemoteDebugConfiguration?

  /home/runner/work/dart-intellij-third-party/dart-intellij-third-party/third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/server/DartRemoteDebugConfiguration.java:61: error: unreported exception CloneNotSupportedException; must be caught or declared to be thrown
      clone.myParameters = myParameters.clone();

Correct-- PR here was to validate that the presubmits are working as intended.

@jwren jwren force-pushed the cq_java_clone_warnings branch from b92895b to 8f83cbf Compare July 21, 2025 20:17
@jwren jwren force-pushed the cq_java_clone_warnings branch from 8f83cbf to e0e9b37 Compare July 21, 2025 20:19
@jwren jwren merged commit 6da2480 into flutter:main Jul 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants