[cq] Migrate code to Inspection-recommended Java 21 APIs

third_party/src/main/java/com/jetbrains/lang/dart/assists/AssistUtils.java

@@ -179,7 +179,7 @@ public static List<SourceEditInfo> applySourceEdits(final @NotNull Project proje
       }
     }
     if (map.isEmpty() && !fileEdits.isEmpty()) {
-      String filePathOrUri = fileEdits.get(0).getFile();
+      String filePathOrUri = fileEdits.getFirst().getFile();
       throw new DartSourceEditException(DartBundle.message("error.none.of.the.files.were.in.this.project.content.0", filePathOrUri));
     }
     return map;
@@ -189,7 +189,7 @@ public static List<SourceEditInfo> applySourceEdits(final @NotNull Project proje
     for (LinkedEditGroup group : sourceChange.getLinkedEditGroups()) {
       final List<Position> positions = group.getPositions();
       if (!positions.isEmpty()) {
-        Position position = positions.get(0);
+        Position position = positions.getFirst();
         String filePathOrUri = position.getFile();
         DartFileInfo fileInfo = DartFileInfoKt.getDartFileInfo(project, filePathOrUri);
         VirtualFile virtualFile = fileInfo.findFile();

third_party/src/main/java/com/jetbrains/lang/dart/fixes/DartQuickFix.java

@@ -94,7 +94,7 @@ public static void doInvoke(@NotNull Project project,
                               @NotNull PsiFile file,
                               @NotNull SourceChange sourceChange,
                               @Nullable DartQuickFix dartQuickFix) {
-    SourceFileEdit fileEdit = sourceChange.getEdits().get(0);
+    SourceFileEdit fileEdit = sourceChange.getEdits().getFirst();
     String filePathOrUri = fileEdit.getFile();
     DartFileInfo fileInfo = DartFileInfoKt.getDartFileInfo(project, filePathOrUri);
     if (!(fileInfo instanceof DartLocalFileInfo localFileInfo)) return;
@@ -191,7 +191,7 @@ public static boolean isPreviewAvailable(@NotNull PsiFile target, @Nullable Sour
       return false;
     }
 
-    String filePathOrUri = sourceChange.getEdits().get(0).getFile();
+    String filePathOrUri = sourceChange.getEdits().getFirst().getFile();
     DartFileInfo fileInfo = DartFileInfoKt.getDartFileInfo(target.getProject(), filePathOrUri);
 
     VirtualFile vFile = target.getOriginalFile().getVirtualFile();
@@ -205,7 +205,7 @@ public static void doInvokeForPreview(@NotNull PsiFile psiFile, @NotNull SourceC
 
     // #isPreviewAvailable() has checked that sourceChange.getEdits().get(0) modifies _this_ PsiFile, not some other
     Document document = psiFile.getViewProvider().getDocument();
-    for (SourceEdit edit : sourceChange.getEdits().get(0).getEdits()) {
+    for (SourceEdit edit : sourceChange.getEdits().getFirst().getEdits()) {
       String replacement = StringUtil.convertLineSeparators(edit.getReplacement());
       int startOffset = edit.getOffset();
       int endOffset = edit.getOffset() + edit.getLength();

third_party/src/main/java/com/jetbrains/lang/dart/ide/actions/DartInheritorsSearcher.java

@@ -124,7 +124,7 @@ private static void prepare(final @NotNull DefinitionsScopedSearch.SearchParamet
     if (hierarchyItems.isEmpty()) return Collections.emptySet();
 
     final Set<DartComponent> result = new HashSet<>(hierarchyItems.size());
-    addSubClasses(project, scope, new HashSet<>(), hierarchyItems, result, hierarchyItems.get(0), false);
+    addSubClasses(project, scope, new HashSet<>(), hierarchyItems, result, hierarchyItems.getFirst(), false);
     return result;
   }
 
@@ -134,7 +134,7 @@ private static void prepare(final @NotNull DefinitionsScopedSearch.SearchParamet
     if (hierarchyItems.isEmpty()) return Collections.emptySet();
 
     final Set<DartComponent> result = new HashSet<>(hierarchyItems.size());
-    addSubMembers(project, scope, new HashSet<>(), hierarchyItems, result, hierarchyItems.get(0), false);
+    addSubMembers(project, scope, new HashSet<>(), hierarchyItems, result, hierarchyItems.getFirst(), false);
     return result;
   }
 

third_party/src/main/java/com/jetbrains/lang/dart/ide/actions/DartServerGotoSuperHandler.java

@@ -45,7 +45,7 @@ public void invoke(@NotNull Project project, @NotNull Editor editor, @NotNull Ps
     // build list of DartComponent(s)
     final List<DartComponent> supers = new ArrayList<>();
     if (!items.isEmpty()) {
-      TypeHierarchyItem seed = items.get(0);
+      TypeHierarchyItem seed = items.getFirst();
       {
         final Integer superIndex = seed.getSuperclass();
         if (superIndex != null) {

third_party/src/main/java/com/jetbrains/lang/dart/ide/actions/DartStyleAction.java

@@ -112,7 +112,7 @@ private static TextRange reformatRange(final @Nullable Editor editor,
     }
 
     final String inputText = document.getText();
-    final String formattedText = StringUtil.convertLineSeparators(edits.get(0).getReplacement());
+    final String formattedText = StringUtil.convertLineSeparators(edits.getFirst().getReplacement());
     if (!wholeFile && countNonSpaceChars(inputText) != countNonSpaceChars(formattedText)) {
       LOG.error("dartfmt changed non-space characters for file " + file.getPath());
       return inputRange;
@@ -189,7 +189,7 @@ public static void runDartfmt(final @NotNull Project project, final @NotNull Lis
         final DartAnalysisServerService.FormatResult formatResult =
           DartAnalysisServerService.getInstance(project).edit_format(virtualFile, 0, 0, lineLength);
         if (formatResult != null && formatResult.getEdits() != null && formatResult.getEdits().size() == 1) {
-          final String replacement = StringUtil.convertLineSeparators(formatResult.getEdits().get(0).getReplacement());
+          final String replacement = StringUtil.convertLineSeparators(formatResult.getEdits().getFirst().getReplacement());
           fileToNewContentMap.put(virtualFile, replacement);
         }
       }

third_party/src/main/java/com/jetbrains/lang/dart/ide/documentation/DartDocUtil.java

@@ -326,7 +326,7 @@ else if (namedComponent instanceof DartEnumConstantDeclaration) {
       if (previous instanceof DartDocComment) {
         return getMultilineDocCommentText((DartDocComment)previous);
       }
-      siblingComments.add(0, (PsiComment)previous);
+      siblingComments.addFirst((PsiComment)previous);
     }
 
     if (!siblingComments.isEmpty()) {

third_party/src/main/java/com/jetbrains/lang/dart/ide/documentation/DartDocumentationProvider.java

@@ -109,7 +109,7 @@ public PsiElement getDocumentationElementForLookupItem(PsiManager psiManager, Ob
     if (hoverList.isEmpty()) {
       return null;
     }
-    return hoverList.get(0);
+    return hoverList.getFirst();
   }
 
   private static @Nullable String constructDocUrl(final @NotNull DartComponent component) {

third_party/src/main/java/com/jetbrains/lang/dart/ide/errorTreeView/DartProblemsTableModel.java

@@ -350,7 +350,7 @@ String getTabTitleText() {
 
     @Nls String statusText;
     if (statusParts.size() == 1) {
-      statusText = statusParts.get(0);
+      statusText = statusParts.getFirst();
     }
     else if (statusParts.size() == 2) {
       statusText = DartBundle.message("dart.problems.view.status.0.and.1", statusParts.get(0), statusParts.get(1));

third_party/src/main/java/com/jetbrains/lang/dart/ide/errorTreeView/DartProblemsViewPanel.java

@@ -100,7 +100,7 @@ public void invokePopup(Component comp, int x, int y) {
     table.getRowSorter().addRowSorterListener(e -> {
       List<? extends RowSorter.SortKey> sortKeys = myTable.getRowSorter().getSortKeys();
       assert sortKeys.size() == 1 : sortKeys;
-      ((DartProblemsTableModel)myTable.getModel()).setSortKey(sortKeys.get(0));
+      ((DartProblemsTableModel)myTable.getModel()).setSortKey(sortKeys.getFirst());
     });
 
     TableSpeedSearch.installOn(table, object -> object instanceof DartProblem
@@ -125,7 +125,7 @@ private void popupInvoked(Component component, int x, int y) {
     group.add(ActionManager.getInstance().getAction(IdeActions.ACTION_COPY));
 
     List<DartProblem> selectedProblems = myTable.getSelectedObjects();
-    DartProblem selectedProblem = selectedProblems.size() == 1 ? selectedProblems.get(0) : null;
+    DartProblem selectedProblem = selectedProblems.size() == 1 ? selectedProblems.getFirst() : null;
 
     addQuickFixActions(group, selectedProblem);
     addDiagnosticMessageActions(group, selectedProblem);

third_party/src/main/java/com/jetbrains/lang/dart/ide/formatter/DartBlock.java

@@ -106,7 +106,7 @@ public boolean isIncomplete() {
     if (previousType == SWITCH_CASE || previousType == DEFAULT_CASE) {
       final List<DartBlock> subBlocks = previousBlock.getSubDartBlocks();
       if (!subBlocks.isEmpty()) {
-        final DartBlock lastChildInPrevBlock = subBlocks.get(subBlocks.size() - 1);
+        final DartBlock lastChildInPrevBlock = subBlocks.getLast();
         final List<DartBlock> subSubBlocks = lastChildInPrevBlock.getSubDartBlocks();
         if (isLastTokenInSwitchCase(subSubBlocks)) {
           return new ChildAttributes(Indent.getNormalIndent(), null);  // e.g. Enter after BREAK_STATEMENT

third_party/src/main/java/com/jetbrains/lang/dart/ide/hierarchy/method/DartMethodHierarchyTreeStructure.java

@@ -43,7 +43,7 @@ public DartMethodHierarchyTreeStructure(Project project, DartComponent element)
     final List<TypeHierarchyItem> items = getTypeHierarchyItems(dartClass);
     if (items.isEmpty()) return ArrayUtilRt.EMPTY_OBJECT_ARRAY;
 
-    addAllVisibleSubclasses(new HashSet<>(), myProject, items, items.get(0), descriptor);
+    addAllVisibleSubclasses(new HashSet<>(), myProject, items, items.getFirst(), descriptor);
     return descriptor.getCachedChildren();
   }
 

third_party/src/main/java/com/jetbrains/lang/dart/ide/hierarchy/type/DartServerSubtypesHierarchyTreeStructure.java

@@ -39,7 +39,7 @@ public DartServerSubtypesHierarchyTreeStructure(final Project project, final Dar
     final List<TypeHierarchyItem> items = getTypeHierarchyItems(dartClass);
     if (items.isEmpty()) return ArrayUtilRt.EMPTY_OBJECT_ARRAY;
 
-    addSubClassHierarchy(new HashSet<>(), myProject, items, items.get(0), descriptor);
+    addSubClassHierarchy(new HashSet<>(), myProject, items, items.getFirst(), descriptor);
     return descriptor.getCachedChildren();
   }
 

third_party/src/main/java/com/jetbrains/lang/dart/ide/hierarchy/type/DartServerSupertypesHierarchyTreeStructure.java

@@ -34,7 +34,7 @@ public DartServerSupertypesHierarchyTreeStructure(final Project project, final D
     final List<TypeHierarchyItem> items = getTypeHierarchyItems(dartClass);
     if (items.isEmpty()) return ArrayUtilRt.EMPTY_OBJECT_ARRAY;
 
-    addSuperClassHierarchy(new HashSet<>(), myProject, items, items.get(0), descriptor);
+    addSuperClassHierarchy(new HashSet<>(), myProject, items, items.getFirst(), descriptor);
 
     return descriptor.getCachedChildren();
   }

third_party/src/main/java/com/jetbrains/lang/dart/ide/hierarchy/type/DartServerTypeHierarchyTreeStructure.java

@@ -47,7 +47,7 @@ public DartServerTypeHierarchyTreeStructure(final Project project, final DartCla
       superDescriptor.setCachedChildren(new HierarchyNodeDescriptor[]{baseDescriptor});
     }
     if (!items.isEmpty()) {
-      addSubClassHierarchy(new HashSet<>(), project, items, items.get(0), baseDescriptor);
+      addSubClassHierarchy(new HashSet<>(), project, items, items.getFirst(), baseDescriptor);
     }
 
     return baseDescriptor;
@@ -73,7 +73,7 @@ public DartServerTypeHierarchyTreeStructure(final Project project, final DartCla
 
     final Set<TypeHierarchyItem> seenItems = new HashSet<>();
     final List<DartClass> superClasses = new ArrayList<>();
-    Integer superIndex = items.get(0).getSuperclass();
+    Integer superIndex = items.getFirst().getSuperclass();
     while (superIndex != null) {
       TypeHierarchyItem superItem = items.get(superIndex);
       if (!seenItems.add(superItem)) {

third_party/src/main/java/com/jetbrains/lang/dart/ide/index/DartLibraryIndex.java

@@ -75,7 +75,7 @@ public static Collection<VirtualFile> getFilesByLibName(final @NotNull GlobalSea
     final DartSdk sdk = DartSdk.getDartSdk(project);
     final List<String> libNames = sdk == null ? null
                                               : getSdkLibUriToRelativePathMap(project, sdk.getHomePath()).getKeysByValue(relativePath);
-    return libNames == null || libNames.isEmpty() ? null : libNames.get(0);
+    return libNames == null || libNames.isEmpty() ? null : libNames.getFirst();
   }
 
   public static @Nullable VirtualFile getSdkLibByUri(final @NotNull Project project, final @NotNull String sdkLibUri) {
@@ -157,7 +157,7 @@ public void visitMapEntry(@NotNull DartMapEntry mapEntry) {
         final DartArguments arguments = newExpression.getArguments();
         final DartArgumentList argumentList = arguments != null ? arguments.getArgumentList() : null;
         final List<DartExpression> expressionList = argumentList != null ? argumentList.getExpressionList() : null;
-        final DartExpression firstExpression = expressionList == null || expressionList.isEmpty() ? null : expressionList.get(0);
+        final DartExpression firstExpression = expressionList == null || expressionList.isEmpty() ? null : expressionList.getFirst();
         final String libraryRelativePath = firstExpression instanceof DartStringLiteralExpression
                                            ? StringUtil.unquoteString(firstExpression.getText())
                                            : null;

third_party/src/main/java/com/jetbrains/lang/dart/ide/marker/DartServerOverrideMarkerProvider.java

@@ -90,7 +90,7 @@ private static void addDartComponent(List<DartComponent> components, Project pro
     }
     else {
       overrides = false;
-      superComponent = interfaceComponents.iterator().next();
+      superComponent = interfaceComponents.getFirst();
     }
     final Icon icon = overrides ? AllIcons.Gutter.OverridingMethod : AllIcons.Gutter.ImplementingMethod;
     PsiElement anchor = PsiTreeUtil.getDeepestFirst(componentName);

third_party/src/main/java/com/jetbrains/lang/dart/ide/refactoring/DartInlineHandler.java

@@ -129,7 +129,7 @@ public boolean isEnabledOnElement(PsiElement element, @Nullable Editor editor) {
     for (DartNavigationRegion region : navigationRegions) {
       if (region.getOffset() <= offset && offset <= region.getOffset() + region.getLength()) {
         final List<DartNavigationTarget> targets = region.getTargets();
-        final String kind = targets.get(0).getKind();
+        final String kind = targets.getFirst().getKind();
         return new InlineRefactoringContext(virtualFile, offset, kind);
       }
     }

third_party/src/main/java/com/jetbrains/lang/dart/ide/refactoring/introduce/DartServerExtractLocalVariableHandler.java

@@ -92,7 +92,7 @@ public void perform() {
     }
     // select the expression to extract
     if (expressions.size() == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
-      performOnExpression(expressions.get(0));
+      performOnExpression(expressions.getFirst());
     }
     else if (expressions.size() > 1) {
       IntroduceTargetChooser.showChooser(editor, expressions, new Pass<>() {

third_party/src/main/java/com/jetbrains/lang/dart/ide/refactoring/status/RefactoringStatus.java

@@ -96,7 +96,7 @@ public void addWarning(@NotNull String msg, @Nullable RefactoringStatusContext c
     if (entries.isEmpty()) {
       return null;
     }
-    RefactoringStatusEntry result = entries.get(0);
+    RefactoringStatusEntry result = entries.getFirst();
     for (RefactoringStatusEntry entry : entries) {
       if (result.getSeverity().ordinal() < entry.getSeverity().ordinal()) {
         result = entry;

third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/server/DartConsoleFolding.java

@@ -68,19 +68,19 @@ public boolean shouldFoldLine(@NotNull Project project, final @NotNull String li
     // depending on the Moon phase (well, on initialization speed) we may get lines.size() == 2 where first line is Dart VM startup and 2nd line is Observatory URL)
     // but more frequently we get these 2 lines one by one
 
-    if (lines.size() == 1 && lines.get(0).startsWith(DartConsoleFilter.OBSERVATORY_LISTENING_ON)) {
-      return " [Debug service available at " + lines.get(0).substring(DartConsoleFilter.OBSERVATORY_LISTENING_ON.length()) + "]";
+    if (lines.size() == 1 && lines.getFirst().startsWith(DartConsoleFilter.OBSERVATORY_LISTENING_ON)) {
+      return " [Debug service available at " + lines.getFirst().substring(DartConsoleFilter.OBSERVATORY_LISTENING_ON.length()) + "]";
     }
-    else if (lines.size() == 1 && lines.get(0).startsWith(DartConsoleFilter.DART_VM_LISTENING_ON)) {
-      return " [Debug service available at " + lines.get(0).substring(DartConsoleFilter.DART_VM_LISTENING_ON.length()) + "]";
+    else if (lines.size() == 1 && lines.getFirst().startsWith(DartConsoleFilter.DART_VM_LISTENING_ON)) {
+      return " [Debug service available at " + lines.getFirst().substring(DartConsoleFilter.DART_VM_LISTENING_ON.length()) + "]";
     }
 
-    if (lines.size() == 1 && lines.get(0).contains(TEST_RUNNER_MARKER)) {
-      return foldTestRunnerCommand(lines.get(0));
+    if (lines.size() == 1 && lines.getFirst().contains(TEST_RUNNER_MARKER)) {
+      return foldTestRunnerCommand(lines.getFirst());
     }
 
-    if (lines.size() == 1 && lines.get(0).contains(WEBDEV_RUNNER_MARKER)) {
-      return foldWebdevCommand(lines.get(0));
+    if (lines.size() == 1 && lines.getFirst().contains(WEBDEV_RUNNER_MARKER)) {
+      return foldWebdevCommand(lines.getFirst());
     }
 
     // exception folding

third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/server/OpenDartObservatoryUrlAction.java

@@ -78,6 +78,6 @@ private static void openInAnyChromeFamilyBrowser(final @NotNull String url) {
     final List<WebBrowser> chromeBrowsers = WebBrowserManager.getInstance().getBrowsers(
       browser -> browser.getFamily() == BrowserFamily.CHROME, true);
 
-    BrowserLauncher.getInstance().browse(url, chromeBrowsers.isEmpty() ? null : chromeBrowsers.get(0));
+    BrowserLauncher.getInstance().browse(url, chromeBrowsers.isEmpty() ? null : chromeBrowsers.getFirst());
   }
 }

third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/server/vmService/VmServiceWrapper.java

@@ -394,7 +394,7 @@ public void received(UriList response) {
 
           List<String> uris = response.getUris();
 
-          if (uris == null || uris.get(0) == null) {
+          if (uris == null || uris.getFirst() == null) {
             LOG.info("Uri was not found");
             JsonObject error = new JsonObject();
             error.addProperty("error", "Breakpoint could not be mapped to package URI");
@@ -404,7 +404,7 @@ public void received(UriList response) {
             return;
           }
 
-          String scriptUri = uris.get(0);
+          String scriptUri = uris.getFirst();
           LOG.info("in received of lookupPackageUris. scriptUri: " + scriptUri);
           myVmService.addBreakpointWithScriptUri(isolateId, scriptUri, line, new AddBreakpointWithScriptUriConsumer() {
             @Override

third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/test/DartTestRunConfigurationProducer.java

@@ -140,7 +140,7 @@ private static boolean setupRunnerParametersForFile(final @NotNull DartTestRunne
 
       runnerParams.setTestName(testName);
       runnerParams.setScope(DartTestRunnerParameters.Scope.GROUP_OR_TEST_BY_NAME);
-      final VirtualFile dartFile = virtualFiles.iterator().next();
+      final VirtualFile dartFile = virtualFiles.getFirst();
       final String dartFilePath = dartFile.getPath();
       runnerParams.setFilePath(dartFilePath);
       return true;

third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/util/DartTestLocationProvider.java

@@ -109,7 +109,7 @@ protected List<Location> getLocationByGroupAndTestNames(final PsiFile psiFile, f
         public boolean execute(final @NotNull PsiElement element) {
           if (element instanceof DartCallExpression expression) {
             if (TestUtil.isTest(expression) || TestUtil.isGroup(expression)) {
-              if (nodes.get(nodes.size() - 1).equals(getTestLabel(expression))) {
+              if (nodes.getLast().equals(getTestLabel(expression))) {
                 boolean matches = true;
                 for (int i = nodes.size() - 2; i >= 0 && matches; --i) {
                   expression = getGroup(expression);
@@ -145,8 +145,8 @@ public boolean execute(final @NotNull PsiElement element) {
     final DartArguments arguments = testCallExpression.getArguments();
     final DartArgumentList argumentList = arguments == null ? null : arguments.getArgumentList();
     final List<DartExpression> argExpressions = argumentList == null ? null : argumentList.getExpressionList();
-    return argExpressions != null && !argExpressions.isEmpty() && argExpressions.get(0) instanceof DartStringLiteralExpression
-           ? StringUtil.unquoteString(argExpressions.get(0).getText())
+    return argExpressions != null && !argExpressions.isEmpty() && argExpressions.getFirst() instanceof DartStringLiteralExpression
+           ? StringUtil.unquoteString(argExpressions.getFirst().getText())
            : null;
   }
 }

third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/util/TestUtil.java

@@ -20,7 +20,7 @@ public final class TestUtil {
     if (dartArgumentList == null || dartArgumentList.getExpressionList().isEmpty()) {
       return null;
     }
-    final DartExpression dartExpression = dartArgumentList.getExpressionList().get(0);
+    final DartExpression dartExpression = dartArgumentList.getExpressionList().getFirst();
     testName = dartExpression == null ? "" : StringUtil.unquoteString(dartExpression.getText());
     return testName;
   }

third_party/src/main/java/com/jetbrains/lang/dart/ide/surroundWith/statement/DartWithTryCatchFinallySurrounder.java

@@ -21,6 +21,6 @@ protected String getTemplateText() {
   @Override
   protected @Nullable PsiElement findElementToDelete(PsiElement surrounder) {
     //noinspection ConstantConditions
-    return ((DartTryStatement)surrounder).getOnPartList().get(0).getBlock().getStatements().getFirstChild(); // todo preselect print(e);
+    return ((DartTryStatement)surrounder).getOnPartList().getFirst().getBlock().getStatements().getFirstChild(); // todo preselect print(e);
   }
 }

third_party/src/main/java/com/jetbrains/lang/dart/ide/surroundWith/statement/DartWithTryCatchSurrounder.java

@@ -21,6 +21,6 @@ protected String getTemplateText() {
   @Override
   protected @Nullable PsiElement findElementToDelete(PsiElement surrounder) {
     //noinspection ConstantConditions
-    return ((DartTryStatement)surrounder).getOnPartList().get(0).getBlock().getStatements().getFirstChild(); // todo preselect print(e);
+    return ((DartTryStatement)surrounder).getOnPartList().getFirst().getBlock().getStatements().getFirstChild(); // todo preselect print(e);
   }
 }