Remove package:codicon dependency
#8592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
reviewed
Dec 5, 2024
devtools_options.yaml
Outdated
| @@ -0,0 +1,3 @@ | |||
| description: This file stores settings for Dart & Flutter DevTools. | |||
elliette
approved these changes
Dec 5, 2024
devoncarew
reviewed
Dec 5, 2024
| async: ^2.0.0 | ||
| clock: ^1.1.1 | ||
| codicon: ^1.0.0 | ||
| async: ^2.0.0 # okay |
Contributor
There was a problem hiding this comment.
The 'okay' text was some local bookkeeping?
Member
Author
There was a problem hiding this comment.
Yeah this was an accidental commit. Feel free to remove as part of #8599 or I can submit a clean up PR.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates the codicon dependency. Instead, we are using the icons from Material Symbols: https://fonts.google.com/icons.
#8591 tracks the work to remove the
codiconpackage fromthird_party.