Register the Property Editor as a standalone screen #8600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
requested review from
bkonyi and
kenzieschmoll
and removed request for
a team
Comment on lines
46
to
53
| StandaloneScreenType.propertyEditor => ValueListenableBuilder( | ||
| valueListenable: dtdManager.connection, | ||
| builder: (context, data, _) { | ||
| return data == null | ||
| ? const CenteredCircularProgressIndicator() | ||
| : PropertyEditorSidebarPanel(data); | ||
| }, | ||
| ), |
Member
There was a problem hiding this comment.
nit: to reduce duplication above can we create a helper widget WaitForDtdConnection or similar?
Member
Author
There was a problem hiding this comment.
Done, created a _DtdConnectedScreen widget!
kenzieschmoll
approved these changes
Dec 5, 2024
kenzieschmoll
approved these changes
Dec 9, 2024
elliette
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #8546
With the changes @DanTup has made in the VS Code extension, this allows us to now test the Property Editor in VS Code 🎉