Skip to content

Conversation

@devoncarew
Copy link
Contributor

  • remove and inline the use of package:ansi_up

This allows us to remove one dep - package:ansi_up. The code for the AnsiParser class is mostly taken from third_party ansi_up/ansi_up.dart, w/ some simplifications and code paths that were never taken removed. It should have the same functionality as the previous code for the parts we were using.

This does not deprecate package:ansi_up, though that would be a good future step.

Please add a note to packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md if your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

@bkonyi bkonyi requested review from kenzieschmoll and removed request for bkonyi December 6, 2024 15:12
@devoncarew devoncarew merged commit ee6877a into flutter:master Dec 6, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants