Add view licenses button to DevTools about dialog that shows license page #8610
Conversation
|
DBC: instead of including "View Licenses" as a dialog action, can it just be another section of the about dialog similar to how Contributing is displayed? additionally, do we need to display the licenses as part of the DevTools web app? Or is linking out to the license file on our repo sufficient? |
Per offline discussion, it was decided to use the same behavior as the "View Licenses" button in the Flutter AboutDialog. |
|
Please add an entry to NEXT_RELEASE_NOTES.md to get the release notes check to pass. |
| /// Since [DevToolsAboutDialog] is not actually an [AboutDialog], there is no | ||
| /// built-in way to add a 'View Licenses' button. | ||
| /// So, adding a custom [DialogTextButton] to view licenses. | ||
| /// Since this action is very specific to just the [DevToolsAboutDialog], | ||
| /// providing implementation in about_dialog.dart and not in | ||
| /// dialogs.dart which contains the definition of [DevToolsDialog]. | ||
| /// TODO(mossmana): We may want to consider refactoring [DevToolsAboutDialog] to be an [AboutDialog]. | ||
| /// https://api.flutter.dev/flutter/material/AboutDialog-class.html |
There was a problem hiding this comment.
this should use // instead of /// since it is not dart doc for the class, but rather comments to explain why we used this approach.
2 participants
#8216
Please add a note to
packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.mdif your change requires release notes. Otherwise, add the 'release-notes-not-required' label to the PR.Pre-launch Checklist
///).![build.yaml badge]