Skip to content

[CPU Profiler] Delete the "Profile app start up" button #9358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

[CPU Profiler] Delete the "Profile app start up" button #9358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions packages/devtools_app/lib/src/screens/profiler/panes/controls/profiler_screen_controls.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import 'package:flutter/material.dart';

import '../../../../shared/analytics/constants.dart' as gac;
import '../../../../shared/framework/screen.dart';
import '../../../../shared/globals.dart';
import '../../../../shared/ui/common_widgets.dart';
import '../../../../shared/ui/file_import.dart';
import '../../../../shared/ui/vm_flag_widgets.dart';
Expand Down Expand Up @@ -103,25 +102,6 @@ class _SecondaryControls extends StatelessWidget {
return Row(
mainAxisAlignment: MainAxisAlignment.end,
children: [
if (serviceConnection
.serviceManager
.connectedApp!
.isFlutterNativeAppNow)
GaDevToolsButton(
icon: Icons.timer,
label: 'Profile app start up',
tooltip:
'Load all Dart CPU samples that occurred before \n'
'the first Flutter frame was drawn (if available)',
tooltipPadding: const EdgeInsets.all(denseSpacing),
gaScreen: gac.cpuProfiler,
gaSelection: gac.CpuProfilerEvents.profileAppStartUp.name,
minScreenWidthForText: _profilingControlsMinScreenWidthForText,
onPressed: !profilerBusy
? controller.cpuProfilerController.loadAppStartUpProfile
: null,
),
const SizedBox(width: denseSpacing),
RefreshButton(
label: 'Load all CPU samples',
tooltip:
Expand Down
4 changes: 3 additions & 1 deletion packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ TODO: Remove this section if there are not any general updates.

## CPU profiler updates

TODO: Remove this section if there are not any general updates.
- Deleted the "Profile app start up" button in favor of the new Dart/Flutter
`--profile-startup` CLI flags. -
[#9358](https://github.com/flutter/devtools/pull/9358)

## Memory updates

Expand Down
7 changes: 0 additions & 7 deletions packages/devtools_app/test/screens/cpu_profiler/profiler_screen_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,6 @@ void main() {
expect(find.byType(StartStopRecordingButton), findsOneWidget);
expect(find.byType(ClearButton), findsOneWidget);
expect(find.text('Load all CPU samples'), findsOneWidget);
if (scene
.fakeServiceConnection
.serviceManager
.connectedApp!
.isFlutterNativeAppNow) {
expect(find.text('Profile app start up'), findsOneWidget);
}
expect(find.byType(CpuSamplingRateDropdown), findsOneWidget);
expect(find.byType(OpenSaveButtonGroup), findsOneWidget);
expect(find.byType(ProfileRecordingInstructions), findsOneWidget);
Expand Down
Loading