Skip to content

Get DevTools tests passing with latest Flutter candidate #9382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,8 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macos-latest, windows-latest]
# TODO(https://github.com/flutter/devtools/issues/9357): Re-enable tests on windows-latest.
os: [macos-latest]
# Consider running integration tests in ddc mode, too.
bot: [integration_dart2js]
device: [flutter, flutter-web, dart-cli]
Expand Down
2 changes: 1 addition & 1 deletion flutter-candidate.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
a9f310a4c91a523c42495a4e528dad76048c01a5
52af7a5040254357f2ab98723b51bbd92d4e6337
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,11 @@
// found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.

// Do not delete these arguments. They are parsed by test runner.
// test-argument:startDevToolsServer=true
// test-argument:appPath="../devtools_extensions/example/app_that_uses_foo"
//
// TODO(https://github.com/flutter/devtools/issues/9378): Re-enable arguments by
// changing "skip-" to "test-" below.
// skip-argument:startDevToolsServer=true
// skip-argument:appPath="../devtools_extensions/example/app_that_uses_foo"

import 'package:devtools_app/devtools_app.dart';
import 'package:devtools_app/src/extensions/embedded/view.dart';
Expand Down Expand Up @@ -161,7 +164,8 @@ void main() {
ExtensionEnabledState.enabled, // foo
ExtensionEnabledState.disabled, // standalone_extension
]);
});
// TODO(https://github.com/flutter/devtools/issues/9378): Re-enable test.
}, skip: true);
}

Future<void> _switchToExtensionScreen(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ class IntegrationTestRunner with IOMixin {
// GitHub Actions. See https://github.com/flutter/devtools/issues/8301.
'--web-browser-flag=--disable-gpu',
if (headless) ...[
// Flags to avoid breakage with chromedriver 128. See
// https://github.com/flutter/devtools/issues/8301.
'--web-browser-flag=--headless=old',
'--web-browser-flag=--disable-search-engine-choice-screen',
// Flags to avoid breakage with chromedriver 138. See
// https://github.com/flutter/devtools/issues/9357.
'--web-browser-flag=--headless=new',
'--web-browser-flag=--no-sandbox',
],
for (final arg in dartDefineArgs) '--dart-define=$arg',
];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ void main() {
app = TestDartApp();
vmServiceUriString = await app!.start();
// Await a short delay to give the VM a chance to initialize.
await delay(duration: const Duration(seconds: 1));
await delay(duration: const Duration(milliseconds: 2500));
expect(vmServiceUriString, isNotEmpty);
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,9 @@ Future<void> closeReleaseNotesViewer(WidgetTester tester) async {
if (releaseNotesView.controller.isVisible.value) {
final closeReleaseNotesButton = find.descendant(
of: find.byType(ReleaseNotesViewer),
matching: find.byType(IconButton),
matching: find.byIcon(Icons.close),
);
expect(closeReleaseNotesButton, findsOneWidget);
await tester.tap(closeReleaseNotesButton);
await tester.tap(closeReleaseNotesButton.first);
}
}

Expand Down
Loading