Skip to content

[DRAFT] Benchmark test failures don't appear in CI #9403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[DRAFT] Benchmark test failures don't appear in CI #9403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
839bd09
Make the test explicitly fail
elliette Aug 19, 2025
9831659
Change where we set fast-fail option
elliette Aug 19, 2025
b859a1f
Merge branch 'master' into issue-9397
elliette Sep 15, 2025
a40abf7
Make benchmarks unrealistic
elliette Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/devtools_app/benchmark/devtools_benchmarks_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ void _verifyScoresAgainstThresholds(
}
}

const _frameTimeFor60FPSInMicros = 16666.6;
const _frameTimeFor60FPSInMicros = 16666.6 / 4;
// const _frameTimeFor30FPSInMicros = 33333.3;

/// Creates the expected [DevToolsBenchmark]s for the specified compiler.
Expand Down
4 changes: 2 additions & 2 deletions tool/ci/benchmark_performance.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.

source ./tool/ci/setup.sh

# Fast fail the script on failures.
set -ex

source ./tool/ci/setup.sh

pushd $DEVTOOLS_DIR/packages/devtools_app
flutter test -j, --concurrency=1 benchmark/devtools_benchmarks_test.dart
popd
Loading