Skip to content

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Oct 7, 2025

This removes FakeTicker and FakeTickerProvider from devtools's tests as they are unused.

This change does not require release notes since it only affects devtools's tests.

Motivation

FakeTicker and FakeTickerProvider implement Ticker and TickerProvider respectively. Since the devtools repo is in Flutter's customer tests, this effectively blocks us from adding any new members to Ticker and TickerProvider.

For example, flutter/flutter#173862 adds a new member to Ticker. This caused customer test failures: link

| Analyzing devtools_app...
|
|   error - test/test_infra/utils/rendering_tester.dart:377:7 - Missing concrete implementations of 'getter class Ticker.forceFrames' and 'setter class Ticker.forceFrames'. Try implementing the missing methods, or make the class abstract. - non_abstract_class_inherits_abstract_member

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or there is a reason for not adding tests.

build.yaml badge

If you need help, consider asking for help on Discord.

@loic-sharma loic-sharma marked this pull request as ready for review October 7, 2025 17:21
@loic-sharma loic-sharma requested a review from a team as a code owner October 7, 2025 17:21
@loic-sharma loic-sharma requested review from kenzieschmoll and removed request for a team October 7, 2025 17:21
Copy link
Member

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@loic-sharma loic-sharma merged commit 75308ea into master Oct 7, 2025
70 of 72 checks passed
@loic-sharma loic-sharma deleted the remove_unused_fake_ticker branch October 7, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants