Skip to content

Fix dt serve command as part of the release process #9603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliette merged 3 commits into from
Jan 13, 2026
+13 −4
Merged

Fix dt serve command as part of the release process #9603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58c7fb2
Fix `dt serve` command as part of the release process
elliette Jan 5, 2026
e7ad66a
Revert "Fix `dt serve` command as part of the release process"
elliette Jan 13, 2026
838abe9
Actually use gclient sync instead of running pub get in the SDK
elliette Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tool/lib/commands/serve.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ class ServeCommand extends Command {
results[SharedCommandArgs.updatePerfetto.flagName] as bool;
final useWasm = results[SharedCommandArgs.wasm.flagName] as bool;
final noStripWasm = results[SharedCommandArgs.noStripWasm.flagName] as bool;
final noMinifyWasm = results[SharedCommandArgs.noMinifyWasm.flagName] as bool;
final noMinifyWasm =
results[SharedCommandArgs.noMinifyWasm.flagName] as bool;
final runPubGet = results[SharedCommandArgs.pubGet.flagName] as bool;
final devToolsAppBuildMode =
results[SharedCommandArgs.buildMode.flagName] as String;
Expand Down Expand Up @@ -241,10 +242,10 @@ class ServeCommand extends Command {
logStatus('completed building DevTools: $devToolsBuildLocation');
}

logStatus('running pub get for DDS in the local dart sdk');
logStatus('running gclient sync in the local dart sdk');
await processManager.runProcess(
CliCommand.dart(['pub', 'get']),
workingDirectory: path.join(localDartSdkLocation, 'pkg', 'dds'),
CliCommand.gclient(['sync']),
workingDirectory: localDartSdkLocation,
);

logStatus('serving DevTools with a local devtools server...');
Expand Down
8 changes: 8 additions & 0 deletions tool/lib/utils.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,14 @@ class CliCommand {
return CliCommand('git', args, throwOnException: throwOnException);
}

/// CliCommand helper for running gclient commands.
factory CliCommand.gclient(
List<String> args, {
bool throwOnException = true,
}) {
return CliCommand('gclient', args, throwOnException: throwOnException);
}

factory CliCommand.tool(List<String> args, {bool throwOnException = true}) {
var toolPath = Platform.script.toFilePath();
if (!File(toolPath).existsSync()) {
Expand Down
Loading