Resolves a "Slow operations are prohibited on EDT" exception #8457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves flutter#8448 Additional work may be needed to limit the number of read actions by the plugin, see flutter#8242
pq
approved these changes
Aug 13, 2025
| if (FlutterSdk.forPath(path) != null) { | ||
| pathsToShow.add(FileUtil.toSystemDependentName(path)); | ||
| // Now, run the slow operation (finding valid SDK paths) on a background thread. | ||
| ApplicationManager.getApplication().executeOnPooledThread(() -> { |
There was a problem hiding this comment.
Neat! I'll have to read up on how this thread pool is managed and what kinds of operations are best run on it. Maybe this is the approach we should take elsewhere?
There was a problem hiding this comment.
It is part of it, I was reading up on coalesceBy, see the message in #8242, which I think will be the right approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #8448
Additional work may be needed to limit the number of read actions by the plugin, see #8242