-
Notifications
You must be signed in to change notification settings - Fork 46
Hotel details. #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Hotel details. #318
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ab350c8
-
polina-c d8efa54
Update travel_carousel.dart
polina-c af65fd8
Update travel_carousel.dart
polina-c f3a6f57
Update travel_carousel.dart
polina-c 85b7fae
-
polina-c 44e7c14
Update travel_carousel.dart
polina-c 9f43364
-
polina-c 0d533f0
Update list_hotels_tool.dart
polina-c 4f10f9b
Revert "Update list_hotels_tool.dart"
polina-c 5debc6b
-
polina-c 72abf56
Update list_hotels_tool_test.dart
polina-c 9b0c3dd
Merge branch 'main' of github.com:flutter/genui into hotel-details
polina-c File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional: How about having a separate subtitle field or something which is shown in a different color, like a grey or something? While it's a small thing, I think it makes the UI look quite a bit more polished to have visually separated sections like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid it may make it more complicated for AI. So, we may loose reliability.
I like the idea. But I would make it P2 and test it carefully. BTW, can be a good item for external contributors.