-
Notifications
You must be signed in to change notification settings - Fork 122
feat: Add granular UI tool controls for create and update #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jacobsimionato
wants to merge
6
commits into
flutter:main
from
jacobsimionato:fix/issue-463-firebase-content-generator-ignores-allow-update
Closed
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6bedd3e
feat: Granular UI tool controls
jacobsimionato 57024a9
Fix tests and formatting
jacobsimionato b538d8a
Reset unnecessary files
jacobsimionato 94bd671
fix: Remove workaround from simple_chat prompt
jacobsimionato f516ba6
docs: Update schema descriptions for surface creation
jacobsimionato 5253d8a
feat: Pass SurfaceUpdateMode to BeginRenderingTool
jacobsimionato File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
examples/travel_app/linux/flutter/generated_plugin_registrant.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| // | ||
| // Generated file. Do not edit. | ||
| // | ||
|
|
||
| // clang-format off | ||
|
|
||
| #include "generated_plugin_registrant.h" | ||
|
|
||
|
|
||
| void fl_register_plugins(FlPluginRegistry* registry) { | ||
| } |
15 changes: 15 additions & 0 deletions
15
examples/travel_app/linux/flutter/generated_plugin_registrant.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // | ||
| // Generated file. Do not edit. | ||
| // | ||
|
|
||
| // clang-format off | ||
|
|
||
| #ifndef GENERATED_PLUGIN_REGISTRANT_ | ||
| #define GENERATED_PLUGIN_REGISTRANT_ | ||
|
|
||
| #include <flutter_linux/flutter_linux.h> | ||
|
|
||
| // Registers Flutter plugins. | ||
| void fl_register_plugins(FlPluginRegistry* registry); | ||
|
|
||
| #endif // GENERATED_PLUGIN_REGISTRANT_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # | ||
| # Generated file, do not edit. | ||
| # | ||
|
|
||
| list(APPEND FLUTTER_PLUGIN_LIST | ||
| ) | ||
|
|
||
| list(APPEND FLUTTER_FFI_PLUGIN_LIST | ||
| ) | ||
|
|
||
| set(PLUGIN_BUNDLED_LIBRARIES) | ||
|
|
||
| foreach(plugin ${FLUTTER_PLUGIN_LIST}) | ||
| add_subdirectory(flutter/ephemeral/.plugin_symlinks/${plugin}/linux plugins/${plugin}) | ||
| target_link_libraries(${BINARY_NAME} PRIVATE ${plugin}_plugin) | ||
| list(APPEND PLUGIN_BUNDLED_LIBRARIES $<TARGET_FILE:${plugin}_plugin>) | ||
| list(APPEND PLUGIN_BUNDLED_LIBRARIES ${${plugin}_bundled_libraries}) | ||
| endforeach(plugin) | ||
|
|
||
| foreach(ffi_plugin ${FLUTTER_FFI_PLUGIN_LIST}) | ||
| add_subdirectory(flutter/ephemeral/.plugin_symlinks/${ffi_plugin}/linux plugins/${ffi_plugin}) | ||
| list(APPEND PLUGIN_BUNDLED_LIBRARIES ${${ffi_plugin}_bundled_libraries}) | ||
| endforeach(ffi_plugin) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For improved conciseness and readability, you could refactor this
switchstatement into aswitchexpression, which is a feature available in modern Dart. This would make the assignment ofsurfaceIdDescriptionmore direct and the code more idiomatic.