Skip to content

Commit d42ed4f

Browse files
committed
update test
1 parent 98b36da commit d42ed4f

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

packages/go_router/CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
## NEXT
22

33
* Updates minimum supported SDK version to Flutter 3.32/Dart 3.8.
4-
4+
a
55
## 17.0.0
66

77
- **BREAKING CHANGE**

packages/go_router/ci_config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
release:
22
# TODO(chunhtai): Opt in when ready.
3-
batch: false
3+
batch: true

packages/go_router/lib/src/configuration.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ import 'route.dart';
1717
import 'router.dart' show GoRouter, OnEnter, RoutingConfig;
1818
import 'state.dart';
1919

20+
int a = 1;
21+
2022
/// The signature of the redirect callback.
2123
typedef GoRouterRedirect =
2224
FutureOr<String?> Function(BuildContext context, GoRouterState state);

script/tool/lib/src/version_check_command.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@ class VersionCheckCommand extends PackageLoopingCommand {
214214
final List<String> changedFiles =
215215
await _gitVersionFinder.getChangedFiles();
216216
// For batch release, we only check pending changelog files.
217+
print('Changed files: $changedFiles');
217218
final List<PendingChangelogEntry> allChangelogs =
218219
<PendingChangelogEntry>[];
219220
try {
@@ -231,6 +232,7 @@ class VersionCheckCommand extends PackageLoopingCommand {
231232
(PendingChangelogEntry entry) => entry.version != VersionChange.skip);
232233

233234
// The changelog.md and pubspec.yaml's version should not be updated directly.
235+
print('package.changelogFile.path: ${package.changelogFile.path}');
234236
if (changedFiles.contains(package.changelogFile.path)) {
235237
printError(
236238
'This package uses batch release, so CHANGELOG.md should not be changed directly.\n'

script/tool/test/version_check_command_test.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -359,9 +359,7 @@ packages/package/pubspec.yaml
359359
);
360360
});
361361

362-
test(
363-
'fails for batch release package with no new changelog',
364-
() async {
362+
test('fails for batch release package with no new changelog', () async {
365363
final RepositoryPackage package =
366364
createFakePackage('package', packagesDir, version: '1.0.0');
367365
package.ciConfigFile.writeAsStringSync('''

0 commit comments

Comments
 (0)