Skip to content

Conversation

blackorbs-dev
Copy link
Contributor

@blackorbs-dev blackorbs-dev commented Sep 29, 2025

setDescription allows switching camera while a video recording is in progress. This feature was only working with camera2 setup, but the camera plugin uses camerax by default. So, this PR includes update to address the issue.

Fixes #148013

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements the ability to switch cameras (setDescription) while a video is recording on Android when using CameraX. This is achieved by introducing a new enablePersistentRecording parameter to the startVideoRecording method. When enabled, the recording session persists through camera switches and lifecycle events. The changes include updating the CameraController to handle this new parameter, adding relevant documentation, and modifying an integration test to verify that recording continues uninterrupted when the camera is switched.

/// Currently a no-op on platforms other than Android.
Future<void> startVideoRecording({
onLatestImageAvailable? onAvailable,
bool enablePersistentRecording = true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Setting enablePersistentRecording to true by default changes the existing behavior of video recording. As the documentation states, a persistent recording will ignore events that would normally stop it, such as lifecycle events. This is a behavioral breaking change for users who might be relying on the previous behavior.

For a patch release, it's best to avoid such breaking changes. I recommend changing the default value to false to make this new persistent recording behavior opt-in. This maintains backward compatibility, and developers who need to switch cameras during recording can explicitly enable it.

If you apply this change, please remember to update the integration test in packages/camera/camera/example/integration_test/camera_test.dart to explicitly call startVideoRecording(enablePersistentRecording: true) to ensure the test for the new functionality continues to pass.

Suggested change
bool enablePersistentRecording = true,
bool enablePersistentRecording = false,

@blackorbs-dev blackorbs-dev changed the title [camera] Implement setDescriptionWhileRecording with android camerax [camera] Implement setDescription with android camerax Sep 29, 2025
@blackorbs-dev
Copy link
Contributor Author

@bparrishMines please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[camera_android_camerax] Implement setDescriptionWhileRecording
1 participant