-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[various] Migrate example Radio groups to new RadioGroup API #10155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexskobozev
wants to merge
22
commits into
flutter:main
Choose a base branch
from
alexskobozev:handle_deprecated_radio_examples
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+132
−124
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
32a6914
[animations] Refactor `Radio` widgets in example
alexskobozev 64064df
[camera] Refactor `Radio` widgets in example
alexskobozev 157a932
[camera] Refactor `Radio` widgets in example
alexskobozev 8109fb3
[camera_android_camerax] Refactor `Radio` widgets in example
alexskobozev bc09c33
[camera_avfoundation] Refactor `Radio` widgets in example
alexskobozev dfc6124
[google_sign_in_web] Refactor `Radio` widgets in example
alexskobozev 57f7be9
[two_dimensional_scrollables] Refactor `Radio` widgets in example
alexskobozev 7b2db36
Fix lints in animations example
alexskobozev fe84be7
[two_dimensional_scrollables] Fix lints in examples
alexskobozev b813cf9
[camera_avfoundation] Format example `main.dart`
alexskobozev 5bcf490
Adds miscellaneous formatting fixes
alexskobozev c6cdb22
Merge remote-tracking branch 'upstream/main' into handle_deprecated_r…
alexskobozev f6b2de3
Update changelogs
alexskobozev 09df509
Revert "Update changelogs"
alexskobozev 7b2347e
Merge remote-tracking branch 'upstream/main' into handle_deprecated_r…
alexskobozev 6c5c615
[google_sign_in_web] Disable RadioListTile when onChanged is null
alexskobozev 3234a2b
[camera_avfoundation] Disable camera selection during recording
alexskobozev aaba578
Update changelogs
alexskobozev 5e347e4
[google_sign_in_web] Simplify `onChanged` callback in example
alexskobozev 3ded134
Merge branch 'main' into handle_deprecated_radio_examples
alexskobozev 2a923fe
[google_sign_in_web] Update onChanged callback in example: pass it as…
alexskobozev 71f6c80
Merge remote-tracking branch 'origin/handle_deprecated_radio_examples…
alexskobozev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
## NEXT | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same applies here; the changes aren't to lib/main.dart. |
||
|
||
* Updates examples to use the new RadioGroup API instead of deprecated Radio parameters. | ||
* Updates minimum supported SDK version to Flutter 3.29/Dart 3.7. | ||
|
||
## 0.3.7 | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we not want to release the updated sample code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub.dev only shows
lib/main.dart
, and the changes in this package aren't to that file, so publishing wouldn't do anything (unless people are running examples out of their pub cache, but that's not something we expect/support in the repo policy).