-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[batch-release] Step3: Adds github action to create a PR to sync changes on the release branch back to the main branch #10393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
| # Fetch all history for all branches | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Create Sync Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is existing github action
- name: Create Pull Request
uses: peter-evans/create-pull-request@v7
with:
token: ${{ secrets.GITHUB_TOKEN }}
commit-message: "...."
title: "...."
body: "...."
branch: release
base: main
| on: | ||
| push: | ||
| branches: | ||
| - 'release' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait, I'm confused about the flow again. How can there be a single release branch that multiple packages are doing releases from while still supporting the async PR approval model? The whole point of using a branch for a release is that the branch can be a snapshot of the state that we want to release for a given package version.
@chunhtai is there a diagram or flow chart in a doc somewhere that shows the final plan for how the branches will work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I forgot about the race condition if we use single branch, where the other package may have merged and brought in new changes.
yeah.. in that case you would need separate release branch for each packages. let me revise the doc a bit and update the issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: #177110
Everytime something is pushed to the release branch, sync it back to the main branch.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3