-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[google_maps_flutter_web] Add Cloud MapStyle color scheme support for web #10471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
martyfuhry
wants to merge
15
commits into
flutter:main
Choose a base branch
from
ReportAll:feat/web-colorscheme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+161
−12
Open
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9cb7faf
Adds support for color scheme
martyfuhry 838a768
adds color scheme to exportrs
martyfuhry e8c04e6
Renames to match naming convention
martyfuhry 5854d68
Bumps version and updates changelog
martyfuhry f79f5c4
Merge branch 'main' into feat/web-colorscheme
martyfuhry ca8153c
updates the pubspec.yaml files to have path-based dependency overrides
martyfuhry c75420c
Updates pubspec.yaml of other touched plugins
martyfuhry 5d53e49
adds CHANGELOG entries to affected federated packages. Reverts mistak…
martyfuhry 24a65c4
Sets default color scheme to follow system and adds simple unit tests
martyfuhry ba0aa0c
Updates comment
martyfuhry 47ff935
Fixes unit test and adds comments to clarify setting color scheme at …
martyfuhry d513046
format tests
martyfuhry 5a03b72
Ran the update-release-info tool to fix changelogs
martyfuhry 2c72b85
Merge branch 'main' into feat/web-colorscheme
martyfuhry 12e3ed6
fixes version change and changelog for platform interface
martyfuhry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
...e_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/map_color_scheme.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| /// The color scheme of the map to be used with cloud styles | ||
| enum MapColorScheme { light, dark, followSystem } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
packages/google_maps_flutter/google_maps_flutter_web/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function can be made more concise by using a switch expression, which is available in this version of Dart. This improves readability by reducing boilerplate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had considered this, but decided to match the style of the below
_gmapTypeIDForPluginTypefunction, which uses the older more verboseswitchsyntax.