[image_picker] Clarify maxDuration parameter behavior #10473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates documentation to explicitly state that the maxDuration parameter only applies when recording videos from the camera (ImageSource.camera), and is ignored when selecting videos from the gallery (ImageSource.gallery). This addresses confusion reported in issue #83630 where developers expected maxDuration to filter gallery video selections, but it only controls camera recording duration. Changes: - Updated README.md with detailed explanation and code examples - Enhanced dartdoc comments for pickVideo() method - Added important notes about gallery selection behavior Fixes flutter/flutter#83630
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request provides a valuable clarification to the documentation for the maxDuration parameter in pickVideo. By explicitly stating that it only applies to camera recordings and is ignored for gallery selections, it addresses a point of common developer confusion. The changes in both the README.md and the Dartdoc comments are clear and well-written. My review includes suggestions to extend this clarification to the pickMultiVideo method as well, to ensure consistency across the package's API, as it exhibits the same behavior.
Extends the documentation clarification to pickMultiVideo() method to maintain consistency across the API. This method only selects from the gallery, so maxDuration is always ignored. Addresses feedback from code review.
Addresses remaining code review feedback by adding pickMultiVideo() to the Video Duration Limitations section in README. The maxDuration parameter is ignored for pickMultiVideo() as well, since it only selects from the gallery. Also added example code showing pickMultiVideo() usage with maxDuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates documentation to explicitly state that the
maxDurationparameter only applies when recording videos from the camera (ImageSource.camera), and is ignored when selecting videos from the gallery (ImageSource.gallery).This addresses confusion reported in issue #83630 where developers expected
maxDurationto filter gallery video selections, but it only controls camera recording duration.Changes
README.mdwith detailed explanation and code examples showing the difference between camera recording and gallery selectionpickVideo()method with important notes about gallery behaviormaxDurationis ignored for gallery selectionsRelated Issues
Fixes flutter/flutter#83630
Pre-launch Checklist
///).