Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g commented Nov 19, 2025

This fixes two sets of API deprecations:

  • Within the package, cloudMapId was deprecated in the platform interface, and replaced with mapId. This updates everything that's not client-facing to use the mapId name instead (except for local variables in native code, where it ensure there's no potential confusion with the plugin-level map ID that tracks map instances in the plugin).
  • Color.value is deprecated. Rather than just replace it with toARGB(), this adds structured data to the Pigeon interface, so that it's not relying on magic knowledge on both sides of the interface that the ints are ARGB:
    • On Android, where the native SDK color representation is just a 32-bit ARGB, this adds a wrapper class to make that explicit in the Pigeon API surface.
    • On iOS, where UIColor uses four doubles, this passes the underlying Color doubles directly via the wrapper class, so that it's not lossy.
    • For legacy JSON representation still used for heatmaps, it just continues to use the equivalent toARGB(). That will change once heatmaps are converted to Pigeon.

This also annotates a couple of intentional internal uses of the deprecated legacy renderer type so that it won't show up in future repository deprecation audits.

Also pays down some tech debt by renaming the now-very-poorly-named FLTGoogleMapJSONConversions.* file to FGMConversionUtils, since it is now mostly Pigeon type conversions. It also renames the legacy FLTGoogleMapJSONConversions bag-of-class-methods class to reflect that it is now only used for heatmaps, the last type that still uses JSON serialization in the Pigeon interface
(flutter/flutter#117907).

Part of flutter/flutter#159739

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

This fixes two sets of API deprecations:
- Within the package, cloudMapId was deprecated in the platform
  interface, and replaced with mapId. This updates everything that's not
  client-facing to use the mapId name instead (except for local
  variables in native code, where it ensure there's no potential
  confusion with the plugin-level map ID that tracks map instances in
  the plugin).
- `Color.value` is deprecated. Rather than just replace it with
  `toARGB()`, this adds structured data to the Pigeon interface, so that
  it's not relying on magic knowledge on both sides of the interface
  that the ints are ARGB:
  - On Android, where the native SDK color representation is just a
    32-bit ARGB, this adds a wrapper class to make that explicit in the
    Pigeon API surface.
  - On iOS, where `UIColor` uses four doubles, this passes the
    underlying `Color` doubles directly via the wrapper class, so that
    it's not lossy.
  - For legacy JSON representations, it continues to use the equivalent
    `toARGB()` directly, since it must remain compatible.

This also annotates a couple of intentional internal uses of the
deprecated `legacy` renderer type so that it won't show up in future
repository deprecation audits.

Also pays down some tech debt by renaming the now-very-poorly-named
FLTGoogleMapJSONConversions.* file to FGMConversionUtils, since it is
now mostly Pigeon type conversions. It also renames the legacy
FLTGoogleMapJSONConversions bag-of-class-methods class to reflect that
it is now only used for heatmaps, the last type that still uses JSON
serialization in the Pigeon interface
(flutter/flutter#117907).

Part of flutter/flutter#159739
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully replaces deprecated APIs, namely cloudMapId and Color.value, across the google_maps_flutter package and its platform implementations. The introduction of a structured PlatformColor type in Pigeon is a significant improvement for type safety and clarity between Dart and native code. The file and class renames to address technical debt are also valuable changes. The overall implementation is systematic and well-executed. I have a few minor suggestions to enhance code clarity by renaming some local variables to align with the new mapId property, which would further improve consistency.

auto-submit bot pushed a commit that referenced this pull request Nov 20, 2025
…face (#10477)

Replaces the deprecated `Color.value` with the replacement `toARGB()`. Since this is for legacy JSON representations, it continues it must remain compatible, so uses the same representation (unlike #10474 where it's replaced with structured representations).

Part of flutter/flutter#159739

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant