[webview_flutter_wkwebview] Add support for javaScriptCanOpenWindowsAutomatically by fummicc1 · Pull Request #10608 · flutter/packages

fummicc1 · 2025-12-11T19:26:36Z

This PR adds support for WKPreferences.javaScriptCanOpenWindowsAutomatically to allow JavaScript's window.open() to work without user interaction on iOS and macOS.

Changes

Added javaScriptCanOpenWindowsAutomatically parameter to WebKitWebViewControllerCreationParams
Exposed setJavaScriptCanOpenWindowsAutomatically method via Pigeon API
The setting is applied when setJavaScriptMode is called

Usage

final controller = WebKitWebViewController(
  WebKitWebViewControllerCreationParams(
    javaScriptCanOpenWindowsAutomatically: true,
  ),
)
  ..setJavaScriptMode(JavaScriptMode.unrestricted)
  ..loadRequest(Uri.parse('https://example.com'));

Proof

I checked this behavior with a demo in this PR

The screen capture below shows that 5 seconds after pressing the button, the WebView shows the destination only if javaScriptCanOpenWindowsAutomatically is true.

Screen.Recording.2025-12-16.at.3.40.48.mp4

…utomatically Adds support for WKPreferences.javaScriptCanOpenWindowsAutomatically to allow JavaScript's window.open() to work without user interaction on iOS and macOS. Fixes flutter/flutter#112276

gemini-code-assist

Code Review

This pull request adds support for javaScriptCanOpenWindowsAutomatically to allow JavaScript's window.open() to work without user interaction on iOS and macOS. The changes are well-implemented across Dart and Swift files, including the necessary Pigeon interface updates, native implementation, and tests. I have a couple of suggestions to improve the code. One is to refactor the setJavaScriptMode method in webkit_webview_controller.dart to reduce code duplication, which will enhance maintainability. The other is a minor improvement in the new Swift test to ensure better error reporting.

packages/webview_flutter/webview_flutter_wkwebview/darwin/Tests/PreferencesProxyAPITests.swift

…matically

…rm defaults

…ntation for setJavaScriptCanOpenWindowsAutomatically to accurately reflect that the default value is `false` on iOS and `true` on macOS, matching Apple's official documentation.

…matically

LongCatIsLooong

LGTM with nits. Thank you for the contribution!

LongCatIsLooong · 2025-12-30T00:06:02Z

packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart

+  /// - iOS: `false`
+  /// - macOS: `true`
+  ///
+  /// See https://developer.apple.com/documentation/webkit/wkpreferences/1536573-javascriptcanopenwindowsautomati


nit, the link doesn't seem to be complete (although the website does seem to redirect you to the correct page). Also I doubt this will be rendered as a link in markdown (so people would have to copy and paste this into their browser's URL bar in order to open it).

Fixed in 96e2b0a.

I reviewed doc comment again and refined in f630604.

LongCatIsLooong · 2025-12-30T00:07:39Z

packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 3.24.0
+
+* Adds support for `javaScriptCanOpenWindowsAutomatically` to allow JavaScript's


uber nit: maybe
WebKitWebViewControllerCreationParams.javaScriptCanOpenWindowsAutomatically so the reader doesn't have to look for the exact name space.

@LongCatIsLooong

Thanks for your view.

Fixed in bcd1d03.

I'm sorry for the confusion but above commit is outdated.
I fixed it again in 7df6f3e

LongCatIsLooong · 2025-12-30T00:10:10Z

Could you re-format the dart code? See https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code

review: flutter#10608 (comment)

…matically

fummicc1 · 2026-01-09T15:27:20Z

@LongCatIsLooong

Thank you for your advice!

I applied formatter by the following code:

dart run script/tool/bin/flutter_plugin_tools.dart format --packages webview_flutter_wkwebview --clang-format-path /opt/homebrew/Cellar/llvm@15/15.0.7/bin/clang-format

…matically

bparrishMines

Thanks for the contribution! Added a small nit for the implementation.

bparrishMines · 2026-02-05T02:38:00Z

packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart

          await webpagePreferences.setAllowsContentJavaScript(true);
      }
+      // Set javaScriptCanOpenWindowsAutomatically on WKPreferences only if explicitly set
+      final bool? javaScriptCanOpenWindowsAutomatically =


nit:

You should be able to move this code above the try block as to not have duplicate code.

Thank you so much.
I fixed it in cf4f2c9.

…matically Resolve merge conflicts in webview_flutter_wkwebview CHANGELOG.md and pubspec.yaml, keeping both the 3.24.0 feature entry and the 3.23.6 bugfix entry.

…c in setJavaScriptMode Move the javaScriptCanOpenWindowsAutomatically setting above the try block to eliminate duplication between the iOS 14+ path and the fallback path. The WKPreferences setting is independent of iOS version. Addresses PR flutter#10608 review feedback (bparrishMines)

Remove duplicated behavioral descriptions and Apple URL from the public API doc, keeping pigeon as the single source of truth. This aligns the documentation style with peer parameters in WebKitWebViewControllerCreationParams.

…HANGELOG.md` review comment: flutter#10608 (comment)

…or-javaScriptCanOpenWindowsAutomatically

bparrishMines

LGTM

[webview_flutter_wkwebview] Add support for javaScriptCanOpenWindowsA…

85e36de

…utomatically Adds support for WKPreferences.javaScriptCanOpenWindowsAutomatically to allow JavaScript's window.open() to work without user interaction on iOS and macOS. Fixes flutter/flutter#112276

fummicc1 requested review from LongCatIsLooong and hellohuanlin as code owners December 11, 2025 19:26

github-actions bot added platform-ios platform-macos p: webview_flutter labels Dec 11, 2025

fummicc1 marked this pull request as draft December 11, 2025 19:27

gemini-code-assist bot reviewed Dec 11, 2025

View reviewed changes

packages/webview_flutter/webview_flutter_wkwebview/darwin/Tests/PreferencesProxyAPITests.swift Outdated Show resolved Hide resolved

fummicc1 added 5 commits December 12, 2025 13:31

Format Swift and Dart files

767e4a5

Merge branch 'main' into add-support-for-javaScriptCanOpenWindowsAuto…

b58764b

…matically

Bump version to 3.24.0 for javaScriptCanOpenWindowsAutomatically feature

bd3b12f

Make javaScriptCanOpenWindowsAutomatically nullable to respect platfo…

4133b20

…rm defaults

Remove failable try to improve test reliability. Updates the docume…

58ecb77

…ntation for setJavaScriptCanOpenWindowsAutomatically to accurately reflect that the default value is `false` on iOS and `true` on macOS, matching Apple's official documentation.

fummicc1 marked this pull request as ready for review December 15, 2025 20:00

Merge branch 'main' into add-support-for-javaScriptCanOpenWindowsAuto…

9dde6ef

…matically

LongCatIsLooong approved these changes Dec 30, 2025

View reviewed changes

fummicc1 added a commit to fummicc1/packages that referenced this pull request Jan 9, 2026

Follow markdown syntax and fix incomplete url.

96e2b0a

review: flutter#10608 (comment)

fummicc1 added a commit to fummicc1/packages that referenced this pull request Jan 9, 2026

Fix CHANGELOG so as to clarfiy changed API.

bcd1d03

review: flutter#10608 (comment)

fummicc1 added 2 commits January 9, 2026 23:56

Merge branch 'main' into add-support-for-javaScriptCanOpenWindowsAuto…

91f96b3

…matically

Format dart code of webview_flutter_wkwebview package.

b5785c7

stuartmorgan-g requested a review from bparrishMines January 20, 2026 19:24

Merge branch 'main' into add-support-for-javaScriptCanOpenWindowsAuto…

a700da7

…matically

bparrishMines requested changes Feb 5, 2026

View reviewed changes

fummicc1 added 5 commits February 9, 2026 21:51

Merge branch 'main' into add-support-for-javaScriptCanOpenWindowsAuto…

ec04126

…matically Resolve merge conflicts in webview_flutter_wkwebview CHANGELOG.md and pubspec.yaml, keeping both the 3.24.0 feature entry and the 3.23.6 bugfix entry.

Apply formatter

0d1533c

Add explicit namespace of WebKitWebViewControllerCreationParams in `C…

7df6f3e

…HANGELOG.md` review comment: flutter#10608 (comment)

fummicc1 requested review from LongCatIsLooong and bparrishMines February 11, 2026 06:17

Merge branch 'main' of github.com:flutter/packages into add-support-f…

130f1c7

…or-javaScriptCanOpenWindowsAutomatically

bparrishMines approved these changes Feb 23, 2026

View reviewed changes

		@@ -1,3 +1,8 @@
		## 3.24.0

		* Adds support for `javaScriptCanOpenWindowsAutomatically` to allow JavaScript's

Conversation

fummicc1 commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Usage

Proof

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fummicc1 Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

fummicc1 Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

fummicc1 Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

fummicc1 Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong commented Dec 30, 2025

Uh oh!

fummicc1 commented Jan 9, 2026

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

bparrishMines Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

fummicc1 Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fummicc1 commented Dec 11, 2025 •

edited

Loading

LongCatIsLooong Dec 30, 2025 •

edited

Loading