-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[video_player] : Add video track selection support for Android and iOS #10688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nateshmbhat
wants to merge
126
commits into
flutter:main
Choose a base branch
from
nateshmbhat:feature/video-track-selection-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+4,137
−381
Open
Changes from 2 commits
Commits
Show all changes
126 commits
Select commit
Hold shift + click to select a range
c8b0071
feat(video_player): add audio track selection support for iOS and And…
nateshmbhat 4e4dc8c
feat(android): implement audio track selection in video player
nateshmbhat 25de26c
feat(video_player): Format Entire Codebase
nateshmbhat 31f9030
feat(video_player): add audio track selection and retrieval functiona…
nateshmbhat 8f711b5
test(video_player): add tests for audio track selection and management
nateshmbhat e0f6d65
fix(video): address PR review comments
nateshmbhat fc30013
Merge branch 'main' into develop
nateshmbhat 8a68e76
fix(video_player): add delay after audio track selection to handle Ex…
nateshmbhat 894f516
test(video_player): update audio tracks test to use ImmutableList and…
nateshmbhat 644e08e
Merge branch 'develop' of github.com:nateshmbhat/flutter_packages int…
nateshmbhat fdde6f8
refactor(tests): move audio track tests from AudioTracksTests.m to Vi…
nateshmbhat 4291609
fix(ios,android): fixed test failure cases (linting and warnings)
nateshmbhat 8dfd8e3
style(audio_tracks): improve code style and add type safety in audio …
nateshmbhat a892a5e
chore(android): bump compileSdk from 34 to 35 for video player plugin
nateshmbhat 1537778
Merge branch 'main' into develop
nateshmbhat c222584
Merge branch 'main' into develop
nateshmbhat f087fe1
refactor(video): improve video player controller handling and code fo…
nateshmbhat 2e4c9ac
Merge branch 'main' into develop
nateshmbhat 652dd48
refactor(video): improve video player state management and UI components
nateshmbhat 80bda36
refactor(ios): improve audio track format parsing with better mock ob…
nateshmbhat 1495a95
refactor(ios): optimize audio track metadata lookup using AVMetadataI…
nateshmbhat ad558a7
refactor(video): move ExoPlayer delay from demo to controller impleme…
nateshmbhat 6c7fd2b
Merge pull request #1 from nateshmbhat/19-sept-pr-review-changes
nateshmbhat 85a8f54
Merge branch 'main' into develop
nateshmbhat ac54143
feat(video_player): add platform check for audio track selection support
nateshmbhat 1775e23
Merge pull request #2 from nateshmbhat/19-sept-pr-review-changes
nateshmbhat 6dafd5f
Merge branch 'develop' of github.com:nateshmbhat/flutter_packages int…
nateshmbhat 9440d1b
style(dart): format code and improve readability with proper line breaks
nateshmbhat a65ebaf
chore(deps): format dependency overrides and add video_player_web path
nateshmbhat 7798aaa
chore(deps): add video_player_web dependency and update package overr…
nateshmbhat e912f6d
fix(video_player): add web platform check for audio track selection d…
nateshmbhat 3ae0519
Merge branch 'main' into develop
nateshmbhat 99cdbd6
fix(video_player): remove fallback labels for audio tracks in Android…
nateshmbhat e7895ef
Merge branch 'main' into develop
nateshmbhat 4e9b50b
Merge branch 'main' into develop
nateshmbhat 5c32bf3
chore(license): update copyright headers in video player files
nateshmbhat 5101efc
chore(license): remove trailing period from copyright headers
nateshmbhat f0bdabd
Merge branch 'main' into develop
nateshmbhat e7b3da0
chore(release): bump video_player packages to next version with audio…
nateshmbhat 6b0de5f
feat(video_player): add audio track management support to platform in…
nateshmbhat 12fd73f
Update packages/video_player/video_player_platform_interface/CHANGELO…
nateshmbhat 680c5e6
feat(video_player): add isAudioTrackSupportAvailable method to platfo…
nateshmbhat c06a83d
Merge branch '4-oct-video-player-interface-updates' of github.com:nat…
nateshmbhat 466946a
Merge branch 'main' into 4-oct-video-player-interface-updates
nateshmbhat 9f391de
Merge branch '4-oct-video-player-interface-updates' into develop
nateshmbhat f85c2bf
refactor(tests): improve formatting of video player test cases
nateshmbhat 5aca457
fix(android): add logging for audio track selection failures in Video…
nateshmbhat 56191a0
docs(video_player): improve documentation for audio track selection m…
nateshmbhat 27336d4
refactor(video_player): move VideoAudioTrack class from platform inte…
nateshmbhat f202438
refactor(video): normalize null handling for audio track metadata acr…
nateshmbhat 3341e2d
refactor(video): change isAudioTrackSupportAvailable from async to sy…
nateshmbhat bba24d3
style(video_player): fix code formatting and indentation
nateshmbhat f89e93b
Merge branch 'main' into develop
nateshmbhat d69fb63
Merge branch 'main' into develop
nateshmbhat 48f7159
feat(android): add audio track selection support for video player
nateshmbhat 1862a7d
chore(deps): update video_player_platform_interface to 6.6.0
nateshmbhat 8046d22
feat(video): simplify video sources and refactor audio track handling
nateshmbhat e2b9a1b
refactor(video_player): simplify audio track data class references
nateshmbhat 00b55ed
chore(deps): update video_player_platform_interface to 6.6.0
nateshmbhat 3c82ead
Based on the git diff, I'll create a commit message that summarizes t…
nateshmbhat 5916b33
Merge branch 'main' into develop
nateshmbhat 5b1e5c7
Here's a commit message summarizing the changes:
nateshmbhat 1161332
perf(ios): optimize audio track selection in video player
nateshmbhat 2811ea2
fix(video_player): improve audio track format handling in tests
nateshmbhat 77a28bb
Merge branch 'main' into develop
nateshmbhat 08e20d3
fix(video_player_avfoundation): update audio track selection for macO…
nateshmbhat c63b050
Merge branch 'main' into develop
nateshmbhat e3df547
refactor(video_player): change audio track selection from string ID t…
nateshmbhat 8d25e52
Merge branch 'main' into develop
nateshmbhat 9f00bf2
chore(video_player): bump iOS minimum deployment target to 13.0
nateshmbhat a7118ee
refactor(video_player_android): improve audio track selection error h…
nateshmbhat d4d0cfd
Merge branch 'main' into develop
nateshmbhat 68d19fe
chore(video_player): update video_player_android dependency to ^2.9.0…
nateshmbhat 941d6c5
Merge branch 'main' into develop
nateshmbhat 6a67d70
feat: add audio track selection functionality to AVFoundation video p…
nateshmbhat 4540ac7
Adds video track selection feature. implemented for android
nateshmbhat 3662630
feat(ios) : adds ios implementation for selecting video track
nateshmbhat 19fbb6f
formatted the files
nateshmbhat 6980c13
fixed analysis errors
nateshmbhat 3bc8e0b
Merge branch 'main' into develop
nateshmbhat 2854bd6
removed android changes
nateshmbhat 7bc3470
reverted web changes
nateshmbhat 6ed1db3
Updated the avfoundation package from 28-oct-platform-avfoundation
nateshmbhat 57f9b9a
formatted all dart files
nateshmbhat 5c06f47
addressed some PR comments
nateshmbhat 15d211f
addressed pr comments
nateshmbhat febcb8c
Merge branch 'main' into feature/video-track-selection-v2
nateshmbhat bbe117d
Merge branch 'main' into develop
nateshmbhat 920c9fc
Merge branch 'main' into feature/video-track-selection-v2
nateshmbhat 14857cd
fix: updated nil usage
nateshmbhat e1fd1b2
Merge branch 'main' into feature/video-track-selection-v2
nateshmbhat ca854fe
fixed dependency overrides
nateshmbhat 43b4598
Merge branch 'main' into feature/video-track-selection-v2
nateshmbhat 5b11cf7
fix(chore): format update
nateshmbhat 6e2f341
Merge branch 'feature/video-track-selection-v2' of github.com:nateshm…
nateshmbhat 33ca127
Merge branch 'main' into feature/video-track-selection-v2
nateshmbhat abf1dcd
chore(video_player): update platform dependencies and remove overrides
nateshmbhat 277c203
Merge branch 'main' into develop
nateshmbhat d0da08c
chore(video_player): revert video_player_avfoundation dependency to ^…
nateshmbhat 23e133a
refactor(video_player): simplify type declarations in tests and example
nateshmbhat f2a06b4
chore(video_player): release version 2.11.0
nateshmbhat 9a46ea6
Merge branch 'main' into develop
nateshmbhat 7fa3024
Merge branch 'main' into feature/video-track-selection-v2
nateshmbhat 1b09e1e
fix: version and changelog updates
nateshmbhat 51f9fa9
Apply suggestion from @LongCatIsLooong
nateshmbhat aab4e4a
refactor(video_player): improve audio tracks demo and API consistency
nateshmbhat 9688aa1
chore(video_player_web): revert version and dependency updates
nateshmbhat c921044
Merge branch 'main' into develop
nateshmbhat da4ea86
refactor(video_player): improve documentation formatting and error te…
nateshmbhat 0e7b21a
Merge branch 'main' into develop
nateshmbhat 16538cc
Merge branch 'main' into develop
nateshmbhat e19f99d
fix: updated interfac prefix usages
nateshmbhat f6559c4
Merge branch 'main' into develop
nateshmbhat 821855f
Merge branch 'main' into develop
nateshmbhat 0ead995
Merge branch 'main' into develop
nateshmbhat 94ce4e3
Merge branch 'main' into develop
nateshmbhat 578bc5d
Merge branch 'main' into develop
camsim99 91f35aa
Merge branch 'main' into develop
stuartmorgan-g 7ac578c
Merge branch 'develop' into feature/video-track-selection-v2
nateshmbhat e069275
[video_player] Refactor video track selection methods and improve err…
nateshmbhat e6a8f21
Merge branch 'main' into develop
nateshmbhat 517524f
Merge branch 'develop' into feature/video-track-selection-v2
nateshmbhat 3c71211
updated format
nateshmbhat ccb2e07
updated mock
nateshmbhat e1d2f36
fix: updated test
nateshmbhat a7d2b0a
Merge branch 'main' into feature/video-track-selection-v2
nateshmbhat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # Uncomment this line to define a global platform for your project | ||
| # platform :ios, '12.0' | ||
| # platform :ios, '13.0' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this change expected? cc @vashworth |
||
|
|
||
| # CocoaPods analytics sends network stats synchronously affecting flutter build latency. | ||
| ENV['COCOAPODS_DISABLE_STATS'] = 'true' | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.