[tool] Adjust error message when downgrade fails
#10734
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `pub downgrade` runs package resolution, failure in that step can simply mean that resolution has failed, rather than indicating a problem with the actual downgrade process. This adjusts the message to make it clear that it's a potential resolver failure, to aid in understanding failures. Fixes flutter/flutter#178815
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adjusts the error message for a failed pub downgrade command within the analyze tool. The message is changed from "Unable to downgrade dependencies" to "Unable to resolve downgraded dependencies" to clarify that the failure is likely due to package resolution issues. A corresponding test that checks for this error message has also been updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
pub downgraderuns package resolution, failure in that step can simply mean that resolution has failed, rather than indicating a problem with the actual downgrade process. This adjusts the message to make it clear that it's a potential resolver failure, to aid in understanding failures.Fixes flutter/flutter#178815