Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Replaces the legacy JSON serialization of heatmaps with fully typed Pigeon data.

Final Android portion of flutter/flutter#117907

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Replaces the legacy JSON serialization of heatmaps with fully typed Pigeon data.

Final Android portion of flutter/flutter#117907
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the Android implementation of heatmaps from a JSON-based serialization to a type-safe approach using Pigeon. The changes are well-executed, replacing manual serialization and deserialization with generated, typed data classes for heatmaps, gradients, and weighted points. This significantly improves code quality, readability, and maintainability by leveraging the type system to prevent runtime errors. The related controllers, data conversion logic, and tests have been updated accordingly, and the overall implementation is clean and robust. No issues were found during the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant