[pointer_interceptor_ios] Migrate XCTest to Swift Testing #10762

jmagman · 2026-01-10T03:55:41Z

Migrate testDebugMode to one parameterized tests, which show up differently in the test UI:

◇ Test run started.
↳ Testing Library Version: 102 (arm64-apple-ios13.0-simulator)
◇ Suite RunnerTests started.
◇ Test debugMode(debug:expectedColor:) started.
◇ Passing 2 arguments debug → false, expectedColor → UIExtendedGrayColorSpace 0 0 to debugMode(debug:expectedColor:)
◇ Passing 2 arguments debug → true, expectedColor → UIExtendedSRGBColorSpace 1 0 0 0.5 to debugMode(debug:expectedColor:)
✔ Test debugMode(debug:expectedColor:) passed after 0.001 seconds.
✔ Suite RunnerTests passed after 0.001 seconds.
✔ Test run with 1 test passed after 0.001 seconds.

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8693093135153504353/+/u/Run_package_tests/native_test/stdout

Adding CHANGELOG override per #10761 (comment)

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

gemini-code-assist

Code Review

This pull request migrates the tests for pointer_interceptor_ios from XCTest to Swift Testing. The changes are well-contained and correctly implement the new testing framework's features. Specifically, RunnerTests.swift is updated to use a single parameterized test with @Test(arguments:), which replaces two separate test methods, making the test suite more concise. The necessary project file updates, such as increasing the Swift version to 6.0, are also included. The CHANGELOG.md is updated accordingly. The migration is clean and follows modern Swift testing practices.

...ges/pointer_interceptor/pointer_interceptor_ios/example/ios/Runner.xcodeproj/project.pbxproj

packages/pointer_interceptor/pointer_interceptor_ios/example/ios/RunnerTests/RunnerTests.swift

packages/pointer_interceptor/pointer_interceptor_ios/example/ios/Runner/AppDelegate.swift

jmagman · 2026-01-10T06:55:31Z

packages/pointer_interceptor/pointer_interceptor_ios/example/ios/RunnerTests/RunnerTests.swift


-class RunnerTests: XCTestCase {
-  func testNonDebugMode() {
+@MainActor


Note if you don't use @MainActor there will be a main thread checker error because the test won't run on the main thread:

PointerInterceptorView.swift:12 UIView.initWithFrame: must be used from main thread only

Though the test still passed. I'm not sure how to make it an error instead of a warning, without converting the whole thing to a test plan (which seems overkill)

You can make this an error by enabling the strict concurrency mode in build settings.

Good idea, I'll play around with how to do that #10788

hellohuanlin

one question about the swift version bump

hellohuanlin · 2026-01-12T19:08:43Z

...ges/pointer_interceptor/pointer_interceptor_ios/example/ios/Runner.xcodeproj/project.pbxproj

 				PRODUCT_BUNDLE_IDENTIFIER = flutter.dev.pointerInterceptorIosExample.RunnerTests;
 				PRODUCT_NAME = "$(TARGET_NAME)";
-				SWIFT_VERSION = 5.0;
+				SWIFT_VERSION = 6.0;


does this version bump have any implication on developers?

No, this is only the plugin example app project, it's not code or an Xcode project a plugin consumer would run.

hellohuanlin · 2026-01-12T19:10:25Z

packages/pointer_interceptor/pointer_interceptor_ios/example/ios/RunnerTests/RunnerTests.swift


-class RunnerTests: XCTestCase {
-  func testNonDebugMode() {
+@MainActor


You can make this an error by enabling the strict concurrency mode in build settings.

hellohuanlin · 2026-01-12T19:11:15Z

packages/pointer_interceptor/pointer_interceptor_ios/example/ios/RunnerTests/RunnerTests.swift

+struct RunnerTests {
+  @Test(arguments: [
+    (false, UIColor.clear),
+    (true, UIColor(red: 1, green: 0, blue: 0, alpha: 0.5)),


convenient!

…lutter/packages#10762)

flutter/packages@98b0325...ce3afa4 2026-01-15 [email protected] Manual roll Flutter from 793b0b8 to b45a73b (8 revisions) (flutter/packages#10799) 2026-01-15 [email protected] [path_provider] Re-release FFI foundation version (flutter/packages#10722) 2026-01-15 [email protected] [google_sign_in] Convert iOS tests to Swift (flutter/packages#10787) 2026-01-14 [email protected] [video_player] Update for UIScene compatibility (flutter/packages#10676) 2026-01-14 [email protected] [pointer_interceptor_ios] Migrate XCTest to Swift Testing (flutter/packages#10762) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r#181035) flutter/packages@98b0325...ce3afa4 2026-01-15 [email protected] Manual roll Flutter from 793b0b8 to b45a73b (8 revisions) (flutter/packages#10799) 2026-01-15 [email protected] [path_provider] Re-release FFI foundation version (flutter/packages#10722) 2026-01-15 [email protected] [google_sign_in] Convert iOS tests to Swift (flutter/packages#10787) 2026-01-14 [email protected] [video_player] Update for UIScene compatibility (flutter/packages#10676) 2026-01-14 [email protected] [pointer_interceptor_ios] Migrate XCTest to Swift Testing (flutter/packages#10762) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[pointer_interceptor_ios] Migrate XCTest to Swift Testing

0e8402f

jmagman self-assigned this Jan 10, 2026

github-actions bot added p: pointer_interceptor platform-ios labels Jan 10, 2026

gemini-code-assist bot reviewed Jan 10, 2026

View reviewed changes

jmagman commented Jan 10, 2026

View reviewed changes

...ges/pointer_interceptor/pointer_interceptor_ios/example/ios/Runner.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved

jmagman commented Jan 10, 2026

View reviewed changes

packages/pointer_interceptor/pointer_interceptor_ios/example/ios/RunnerTests/RunnerTests.swift Outdated Show resolved Hide resolved

jmagman marked this pull request as ready for review January 10, 2026 04:19

jmagman requested review from LouiseHsu and hellohuanlin as code owners January 10, 2026 04:19

jmagman mentioned this pull request Jan 10, 2026

Migrate iOS plugin tests from XCTest to Swift Testing flutter/flutter#180787

Open

18 tasks

shift MainActor to struct

be3e199

jmagman commented Jan 10, 2026

View reviewed changes

packages/pointer_interceptor/pointer_interceptor_ios/example/ios/Runner/AppDelegate.swift Outdated Show resolved Hide resolved

jmagman commented Jan 10, 2026

View reviewed changes

hellohuanlin approved these changes Jan 12, 2026

View reviewed changes

LouiseHsu approved these changes Jan 12, 2026

View reviewed changes

Remove CHANGELOG, revert let

7c320fa

jmagman added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jan 14, 2026

jmagman mentioned this pull request Jan 14, 2026

[ci] Enforce Swift 6 strict concurrency during testing #10788

Draft

11 tasks

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 14, 2026

auto-submit bot merged commit c4995d0 into flutter:main Jan 14, 2026
81 checks passed

jmagman deleted the pointer-interceptor-st branch January 15, 2026 00:10

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 15, 2026

c4995d0e9 [pointer_interceptor_ios] Migrate XCTest to Swift Testing (f…

cc2004f

…lutter/packages#10762)

engine-flutter-autoroll mentioned this pull request Jan 15, 2026

Roll Packages from 98b0325fc86e to ce3afa467840 (5 revisions) flutter/flutter#181035

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[pointer_interceptor_ios] Migrate XCTest to Swift Testing #10762

[pointer_interceptor_ios] Migrate XCTest to Swift Testing #10762

jmagman commented Jan 10, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman Jan 10, 2026 •

edited

Loading

Uh oh!

hellohuanlin Jan 12, 2026

Uh oh!

jmagman Jan 14, 2026

Uh oh!

hellohuanlin left a comment

Uh oh!

hellohuanlin Jan 12, 2026

Uh oh!

jmagman Jan 13, 2026

Uh oh!

hellohuanlin Jan 12, 2026

Uh oh!

hellohuanlin Jan 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[pointer_interceptor_ios] Migrate XCTest to Swift Testing #10762

[pointer_interceptor_ios] Migrate XCTest to Swift Testing #10762

Conversation

jmagman commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jmagman Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

jmagman Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

hellohuanlin left a comment

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

jmagman Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jmagman commented Jan 10, 2026 •

edited

Loading

jmagman Jan 10, 2026 •

edited

Loading