-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[url_launcher_macos] Migrate XCTest to Swift Testing #10763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully migrates the url_launcher_macos tests from XCTest to the new Swift Testing framework. The changes are well-executed, leveraging test parameterization to reduce boilerplate and combine related test cases. A significant improvement is the consistent use of StubWorkspace across all tests, converting what were previously integration tests into true unit tests. I've included one suggestion to further improve code reuse within the test suite.
packages/url_launcher/url_launcher_macos/example/macos/RunnerTests/RunnerTests.swift
Show resolved
Hide resolved
|
Adding CHANGELOG override per #10761 (comment) |
flutter/packages@eb9e1dc...98b0325 2026-01-14 [email protected] [url_launcher_macos] Migrate XCTest to Swift Testing (flutter/packages#10763) 2026-01-14 [email protected] [path_provider_foundation] Migrate XCTest to Swift Testing (flutter/packages#10761) 2026-01-13 [email protected] Roll Flutter from d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784) 2026-01-13 [email protected] [google_fonts] Add missing public API documentation (flutter/packages#10782) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#180983) flutter/packages@eb9e1dc...98b0325 2026-01-14 [email protected] [url_launcher_macos] Migrate XCTest to Swift Testing (flutter/packages#10763) 2026-01-14 [email protected] [path_provider_foundation] Migrate XCTest to Swift Testing (flutter/packages#10761) 2026-01-13 [email protected] Roll Flutter from d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784) 2026-01-13 [email protected] [google_fonts] Add missing public API documentation (flutter/packages#10782) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#180983) flutter/packages@eb9e1dc...98b0325 2026-01-14 [email protected] [url_launcher_macos] Migrate XCTest to Swift Testing (flutter/packages#10763) 2026-01-14 [email protected] [path_provider_foundation] Migrate XCTest to Swift Testing (flutter/packages#10761) 2026-01-13 [email protected] Roll Flutter from d81cd3e to 793b0b8 (18 revisions) (flutter/packages#10784) 2026-01-13 [email protected] [google_fonts] Add missing public API documentation (flutter/packages#10782) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Part of flutter/flutter#180787
Add some test parameterization.
Also, only two of the tests were using the
StubWorkspace, so were actually integration testing my local Mac's ability tocanLaunchURLs. Swap them all to use the stub.https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8693089115880026769/+/u/Run_package_tests/native_test/stdout
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3