-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[two_dimensional_scrollables] Migrate XCTest to Swift Testing #10764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates the native tests for the two_dimensional_scrollables example on iOS and macOS from XCTest to the new Swift Testing framework. This involves updating the Swift test files to use the new @Test macro and Testing module, and updating the Xcode project files to set the Swift language version to 6.0 for the test targets. The CHANGELOG.md is also updated to reflect this change.
Piinks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you!
|
These tests should just be removed; it's the placeholder that's part of the template, and we don't ever expect to run these tests in a non-plugin package like this one. Usually we remove them, it just got missed here. It's dead code from a repo tool perspective, because we won't try to run these tests for a non-plugin package. |
@stuartmorgan-g Is the right thing to do remove the platform directories from |
|
We should leave the platform directory so it's easy to run the example. I'm not sure why We should just delete the test file and the XCode test target. |
|
Part of flutter/flutter#180787
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3