Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 10, 2026

Part of flutter/flutter#180787

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@github-actions github-actions bot added platform-ios platform-macos p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package triage-framework Should be looked at in framework triage labels Jan 10, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the native tests for the two_dimensional_scrollables example on iOS and macOS from XCTest to the new Swift Testing framework. This involves updating the Swift test files to use the new @Test macro and Testing module, and updating the Xcode project files to set the Swift language version to 6.0 for the test targets. The CHANGELOG.md is also updated to reflect this change.

@jmagman jmagman marked this pull request as ready for review January 10, 2026 05:57
@jmagman jmagman requested a review from Piinks as a code owner January 10, 2026 05:57
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@stuartmorgan-g
Copy link
Collaborator

These tests should just be removed; it's the placeholder that's part of the template, and we don't ever expect to run these tests in a non-plugin package like this one. Usually we remove them, it just got missed here.

It's dead code from a repo tool perspective, because we won't try to run these tests for a non-plugin package.

@jmagman
Copy link
Member Author

jmagman commented Jan 14, 2026

Usually we remove them, it just got missed here.

@stuartmorgan-g Is the right thing to do remove the platform directories from packages/two_dimensional_scrollables/example, similar to packages/vector_graphics/example ? Or just remove the platform tests?

@jmagman jmagman marked this pull request as draft January 14, 2026 05:05
@stuartmorgan-g
Copy link
Collaborator

We should leave the platform directory so it's easy to run the example. I'm not sure why vector_graphics doesn't have platform directories; I didn't change it when we imported it from Dan's repo. We don't have a proactive policy about what platforms are in example directories, so it's kind of a hodgepodge right now (e.g., lots of examples don't have desktop support because they predate stable desktop). It's on my mental list of things to try to standardize at some point, but it's pretty far down at the moment.

We should just delete the test file and the XCode test target.

@jmagman jmagman changed the title [two_dimensional_scrollables] Migrate XCTest to Swift Testing [two_dimensional_scrollables] Delete placeholder iOS and macOS tests Jan 15, 2026
@jmagman jmagman changed the title [two_dimensional_scrollables] Delete placeholder iOS and macOS tests [two_dimensional_scrollables] Migrate XCTest to Swift Testing Jan 15, 2026
@jmagman jmagman closed this Jan 15, 2026
@jmagman jmagman deleted the tds-st branch January 15, 2026 04:28
@jmagman
Copy link
Member Author

jmagman commented Jan 15, 2026

We should just delete the test file and the XCode test target.

#10801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: two_dimensional_scrollables Issues pertaining to the two_dimensional_scrollables package platform-ios platform-macos triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants