-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[url_launcher_ios] Migrate XCTest to Swift Testing #10780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request migrates the url_launcher_ios unit tests from XCTest to Swift Testing. This involves updating the Swift version to 6.0 in the project configuration and rewriting the tests in URLLauncherTests.swift. The XCTest APIs are replaced with Swift Testing APIs, such as using @Test instead of XCTestCase methods, #expect for assertions, and await confirmation for asynchronous operations. Some tests have been combined and parameterized, such as canLaunch and launch, reducing code duplication.
packages/url_launcher/url_launcher_ios/example/ios/RunnerTests/URLLauncherTests.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Hm that doesn't look good... |
Actually this warning was happening before my change, probably because I'll ignore it since it's not related to the Swift Testing change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully migrates the url_launcher_ios example tests from XCTest to the modern Swift Testing framework. The changes include updating the project to Swift 6.0, refactoring test classes into @MainActor structs, and adopting new Swift Testing APIs like @Test, #expect, and async confirmations. A notable improvement is the use of parameterized tests, which consolidates several test cases and makes the test suite more concise. My review focuses on ensuring the migration correctly preserves the original testing intent, especially regarding how error conditions are handled.
Part of flutter/flutter#180787
Add some test parameterization.
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8692848274232556065/+/u/Run_package_tests/native_test/stdout
Adding CHANGELOG override per #10761 (comment)
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3