Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 13, 2026

Part of flutter/flutter#180787

Test passing:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8692723844540973921/+/u/Run_package_tests/native_test/stdout#L16311_1

Adding CHANGELOG override per #10761 (comment)

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@jmagman jmagman force-pushed the ima-st branch 2 times, most recently from 789ab33 to 7207486 Compare January 13, 2026 22:57
@jmagman jmagman added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jan 14, 2026
var registerFriendlyObstructionArgs: [AnyHashable?]? = nil
var unregisterAllFriendlyObstructionsCalled = false

convenience init() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted this convenience method because IMAAdDisplayContainer is still an Objective-C class, and creating @MainActor classes like UIView in a non-MainActor init, I was doing acrobatics with like MainActor.assumeIsolated, but IMACompanionAdSlot is also an Objective-C class, so it wasn't @Sendable, which it needs to be when returned from MainActor.assumeIsolated, etc, etc.

There's some duplication in the tests now, but the one @unchecked Sendable is cleaner than all that.

@jmagman jmagman marked this pull request as ready for review January 14, 2026 06:39
@jmagman jmagman requested a review from okorohelijah January 14, 2026 06:39
@jmagman
Copy link
Member Author

jmagman commented Jan 14, 2026

Sorry this review is huge, but other than AdDisplayContainerTests.swift it's almost entirely mechanical 1:1.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully migrates the iOS tests for interactive_media_ads from XCTest to the new Swift Testing framework. The changes are generally well-executed, updating imports, test structures, and assertions. I've provided several suggestions to further improve the tests by consistently using try with throws for test functions that call throwing methods. This will enhance test clarity and provide better failure diagnostics, aligning with modern Swift testing practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

override: no changelog needed Override the check requiring CHANGELOG updates for most changes p: interactive_media_ads Plugin for IMA SDK platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant