-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[interactive_media_ads] Migrate XCTest to Swift Testing #10786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
789ab33 to
7207486
Compare
| var registerFriendlyObstructionArgs: [AnyHashable?]? = nil | ||
| var unregisterAllFriendlyObstructionsCalled = false | ||
|
|
||
| convenience init() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted this convenience method because IMAAdDisplayContainer is still an Objective-C class, and creating @MainActor classes like UIView in a non-MainActor init, I was doing acrobatics with like MainActor.assumeIsolated, but IMACompanionAdSlot is also an Objective-C class, so it wasn't @Sendable, which it needs to be when returned from MainActor.assumeIsolated, etc, etc.
There's some duplication in the tests now, but the one @unchecked Sendable is cleaner than all that.
|
Sorry this review is huge, but other than |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully migrates the iOS tests for interactive_media_ads from XCTest to the new Swift Testing framework. The changes are generally well-executed, updating imports, test structures, and assertions. I've provided several suggestions to further improve the tests by consistently using try with throws for test functions that call throwing methods. This will enhance test clarity and provide better failure diagnostics, aligning with modern Swift testing practices.
Part of flutter/flutter#180787
Test passing:
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8692723844540973921/+/u/Run_package_tests/native_test/stdout#L16311_1
Adding CHANGELOG override per #10761 (comment)
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3