Skip to content

Conversation

@ValentinVignal
Copy link
Contributor

Relates to flutter/flutter#112152

Adds TypedGoRouteParameter annotation

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@github-actions github-actions bot added p: go_router triage-framework Should be looked at in framework triage labels Jan 14, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the TypedGoRouteParameter annotation, which allows developers to customize URI parameter names in type-safe routes. The changes include the new annotation class, updates to the pubspec.yaml and CHANGELOG.md, and a unit test for the new class. My feedback focuses on ensuring the documentation for this new feature is clear and consistent with existing conventions.

@ValentinVignal
Copy link
Contributor Author

go_router_builder PR: #10793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: go_router triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant