Skip to content

test xcode 26 beta 4 #9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,25 +93,25 @@ platform_properties:
[
{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
]
os: Mac-14|Mac-15.5
os: Mac-15
device_type: none
cpu: arm64
$flutter/osx_sdk : >-
{
"sdk_version": "16c5032a"
"sdk_version": "17a5285i"
}
mac_x64:
properties:
dependencies: >-
[
{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
]
os: Mac-14|Mac-15.5
os: Mac-15
device_type: none
cpu: x86
$flutter/osx_sdk : >-
{
"sdk_version": "16c5032a"
"sdk_version": "17a5285i"
}

targets:
Expand Down Expand Up @@ -1084,7 +1084,6 @@ targets:

- name: Mac_arm64 macos_platform_tests stable - packages
recipe: packages/packages
presubmit: false
timeout: 60
properties:
channel: stable
Expand Down Expand Up @@ -1220,7 +1219,6 @@ targets:
# Don't run full platform tests on both channels in pre-submit.
- name: Mac_arm64 ios_platform_tests_shard_1 stable
recipe: packages/packages
presubmit: false
timeout: 60
properties:
channel: stable
Expand All @@ -1235,7 +1233,6 @@ targets:

- name: Mac_arm64 ios_platform_tests_shard_2 stable
recipe: packages/packages
presubmit: false
timeout: 60
properties:
channel: stable
Expand All @@ -1250,7 +1247,6 @@ targets:

- name: Mac_arm64 ios_platform_tests_shard_3 stable
recipe: packages/packages
presubmit: false
timeout: 60
properties:
channel: stable
Expand All @@ -1265,7 +1261,6 @@ targets:

- name: Mac_arm64 ios_platform_tests_shard_4 stable
recipe: packages/packages
presubmit: false
timeout: 60
properties:
channel: stable
Expand All @@ -1280,7 +1275,6 @@ targets:

- name: Mac_arm64 ios_platform_tests_shard_5 stable
recipe: packages/packages
presubmit: false
timeout: 60
properties:
channel: stable
Expand Down
2 changes: 1 addition & 1 deletion .ci/scripts/create_simulator.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ set -o pipefail
# The name here must match remove_simulator.sh
readonly DEVICE_NAME=Flutter-iPhone
readonly DEVICE=com.apple.CoreSimulator.SimDeviceType.iPhone-14
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-18-2
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-26-0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The iOS simulator runtime version iOS-26-0 appears to be incorrect, as there is no public iOS version 26. This is likely a typo and should probably be iOS-18-0 to align with Xcode 16 beta. An incorrect runtime version will cause CI builds to fail.

Suggested change
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-26-0
readonly OS=com.apple.CoreSimulator.SimRuntime.iOS-18-0


# Delete any existing devices named Flutter-iPhone. Having more than one may
# cause issues when builds target the device.
Expand Down
2 changes: 1 addition & 1 deletion .ci/targets/ios_platform_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ tasks:
- name: native test
script: .ci/scripts/tool_runner.sh
# Simulator name and version must match name and version in create_simulator.sh
args: ["native-test", "--ios", "--ios-destination", "platform=iOS Simulator,name=Flutter-iPhone,OS=18.2", "--xcode-warnings-exceptions=script/configs/xcode_warnings_exceptions.yaml"]
args: ["native-test", "--ios", "--ios-destination", "platform=iOS Simulator,name=Flutter-iPhone,OS=26.0", "--xcode-warnings-exceptions=script/configs/xcode_warnings_exceptions.yaml"]
- name: boot simulator
# Ensure simulator is still booted
script: .ci/scripts/boot_simulator.sh
Expand Down
4 changes: 2 additions & 2 deletions packages/pigeon/tool/shared/test_suites.dart
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,8 @@ Future<int> _runIOSPluginUnitTests(String testPluginPath) async {

const String deviceName = 'Pigeon-Test-iPhone';
const String deviceType = 'com.apple.CoreSimulator.SimDeviceType.iPhone-14';
const String deviceRuntime = 'com.apple.CoreSimulator.SimRuntime.iOS-18-2';
const String deviceOS = '18.2';
const String deviceRuntime = 'com.apple.CoreSimulator.SimRuntime.iOS-26-0';
const String deviceOS = '26.0';
Comment on lines +330 to +331

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The iOS simulator runtime and OS versions appear to be incorrect. There is no public iOS 26.0. This is likely a typo and should probably be iOS-18-0 and 18.0 respectively, to align with Xcode 16 beta. Using an invalid runtime will cause CI failures.

  const String deviceRuntime = 'com.apple.CoreSimulator.SimRuntime.iOS-18-0';
  const String deviceOS = '18.0';

await _createSimulator(deviceName, deviceType, deviceRuntime);
return runXcodeBuild(
'$examplePath/ios',
Expand Down
1 change: 1 addition & 0 deletions script/tool/lib/src/podspec_check_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ class PodspecCheckCommand extends PackageLoopingCommand {
podspecPath,
'--configuration=Debug', // Release targets unsupported arm64 simulators. Use Debug to only build against targeted x86_64 simulator devices.
'--skip-tests',
'--allow-warnings',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding --allow-warnings can hide legitimate issues introduced by the new SDK. While it can be a temporary measure to unblock CI, this should be tracked to ensure the underlying warnings are eventually fixed and this flag is removed. Please add a TODO comment to track this.

if (libraryLint) '--use-libraries'
];

Expand Down
4 changes: 4 additions & 0 deletions script/tool/test/podspec_check_command_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
'--use-libraries'
],
packagesDir.path),
Expand All @@ -169,6 +170,7 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
],
packagesDir.path),
]),
Expand Down Expand Up @@ -209,6 +211,7 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
'--use-libraries'
],
packagesDir.path),
Expand All @@ -223,6 +226,7 @@ void main() {
.path,
'--configuration=Debug',
'--skip-tests',
'--allow-warnings',
],
packagesDir.path),
]),
Expand Down