[url_launcher_ios] Fix test button text to work on iOS 26 #9766
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the iOS UI tests to handle different button labels for the 'Done' button in SFSafariViewController across different iOS versions. The change correctly uses an NSPredicate to find the button. However, the review identifies two points for improvement: the changelog entry could be clearer for public consumption, and assertions for other UI elements have been removed from the test, which reduces test coverage without explanation. These should be either restored or their removal justified.
Draft
LongCatIsLooong
approved these changes
Aug 14, 2025
| XCTAssertTrue(app.buttons["Share"].exists) | ||
| XCTAssertTrue(app.buttons["OpenInSafariButton"].exists) | ||
| let doneButton = app.buttons["Done"] | ||
| XCTAssertTrue(app.buttons["OpenInSafariButton"].waitForExistence(timeout: 30.0)) |
There was a problem hiding this comment.
Does the CI run this test on xcode 26, or I should manually verify this change?
There was a problem hiding this comment.
I tested this in a PR draft running Xcode 26 beta 5 #9748. I rebased that branch onto this one. It failed before, but now passes:
Testing started
Successfully ran iOS xctest for packages/url_launcher/url_launcher_ios/example
[packages/url_launcher/url_launcher_ios completed in 1m 29s]
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 15, 2025
flutter/packages@09533b7...5c52c55 2025-08-15 [email protected] [video_player] Move Android buffer updates to Dart (flutter/packages#9771) 2025-08-15 [email protected] [webview_flutter] Add support for payment requests on Android (flutter/packages#9679) 2025-08-15 [email protected] [vector_graphics_compiler] Set the m4_10 (Z scale) value to 1 when constructing an AffineMatrix from an SVG matrix (flutter/packages#9813) 2025-08-15 [email protected] [url_launcher_ios] Fix test button text to work on iOS 26 (flutter/packages#9766) 2025-08-15 [email protected] [video_player] Simplify native iOS code (flutter/packages#9800) 2025-08-14 [email protected] [image_picker] Add the ability to pick multiple videos - platform_interface (flutter/packages#9804) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle either a "Done" (iOS 18) or a "Close" (iOS 26) button:
iOS 26 simulator:
Remove validation of UI elements (
ForwardButton,Share) that the plugin doesn't control.Fixes flutter/flutter#173100
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3