Fix maps web style conflict #9783
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a conflict between cloud-based map styling (cloudMapId) and the styles property by ensuring styles are only applied when cloudMapId is not present. The change is logical and well-implemented. My main feedback is to add a test case to cover this new logic to prevent future regressions, as per the repository's best practices.
packages/google_maps_flutter/google_maps_flutter_web/lib/src/convert.dart
Show resolved
Hide resolved
|
Once you've signed the CLA, please mark as ready for review; we're not able to review PRs without a CLA. |
WillBLogical
force-pushed
the
fix-maps-web-style-conflict
branch
2 times, most recently
from
148aab0 to
c36c6a5
Compare
Fixes #161951 When a 'cloudMapId' is used, the Google Maps JS API does not allow the `styles` property to be set on the map options. This change modifies the `_configurationAndStyleToGmapsOptions` method to ensure that the `styles` property is only applied when `configuration.mapId` is null. This resolves the console warning and allows cloud-based styling to work as intended.
WillBLogical
force-pushed
the
fix-maps-web-style-conflict
branch
from
c36c6a5 to
9a0efd4
Compare
I signed the CLA. |
Please see the output of the CI failures, which will need to be resolved. Currently the changes to the test file don't compile. |
WillBLogical
force-pushed
the
fix-maps-web-style-conflict
branch
3 times, most recently
from
66c9d9f to
f00e440
Compare
WillBLogical
force-pushed
the
fix-maps-web-style-conflict
branch
from
f00e440 to
c293618
Compare
Everything has passed |
Fixes #161951
When a 'cloudMapId' is used, the Google Maps JS API does not allow the
stylesproperty to be set on the map options.This change modifies the
_configurationAndStyleToGmapsOptionsmethod to ensure that thestylesproperty is only applied whenconfiguration.mapIdis null. This resolves the console warning and allows cloud-based styling to work as intended.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3